Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1876 - Explicitly declare the used features for each dependency #1877

Merged
merged 3 commits into from Jun 15, 2022

Conversation

martin-g
Copy link
Member

Which issue does this PR close?

This is the first PR for #1876.
It changes just arrow/Cargo.toml. If approved then I will do the same for the other modules too!
The PR does not upgrade the dependencies!

The changes are tested locally with cargo +nightly test --all-features. I've fixed a missing parameter in a method/constructor call.

Rationale for this change

Reduce the disk and CPU usage at build time.

What changes are included in this PR?

N/A

Are there any user-facing changes?

No.

…endency

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 14, 2022
@martin-g martin-g closed this Jun 14, 2022
@martin-g martin-g reopened this Jun 14, 2022
…ev-dependencies

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@codecov-commenter
Copy link

Codecov Report

Merging #1877 (0b6cd28) into master (cedaf8a) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1877      +/-   ##
==========================================
- Coverage   83.46%   83.46%   -0.01%     
==========================================
  Files         201      201              
  Lines       57014    57018       +4     
==========================================
+ Hits        47586    47589       +3     
- Misses       9428     9429       +1     
Impacted Files Coverage Δ
arrow/src/csv/writer.rs 71.69% <ø> (ø)
parquet/src/encodings/encoding.rs 93.46% <0.00%> (-0.20%) ⬇️
arrow/src/ffi.rs 86.97% <0.00%> (ø)
arrow/src/array/ffi.rs 100.00% <0.00%> (ø)
arrow/src/ffi_stream.rs 79.89% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cedaf8a...0b6cd28. Read the comment docs.

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you

@martin-g
Copy link
Member Author

Thanks, @tustvold !
I will start working on the other modules too.
I will open a separate PR for each module!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants