Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1876: Explicitly declare the used features for each dependency in parquet #1881

Merged

Conversation

martin-g
Copy link
Member

Which issue does this PR close?

This is the third PR for #1876.
It changes just parquet/Cargo.toml.
The PR does not upgrade the dependencies!

Previous PRs:

Rationale for this change

Reduce the disk and CPU usage at build time.

What changes are included in this PR?

N/A

Are there any user-facing changes?

N/A

@github-actions github-actions bot added the parquet Changes to the parquet crate label Jun 15, 2022
…ndency in parquet

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g martin-g force-pushed the arrow-1876-disable-default-features-parquet branch from 9e3a06c to 96603b3 Compare June 15, 2022 13:11
@alamb alamb requested a review from tustvold June 16, 2022 19:58
@tustvold tustvold merged commit f411a98 into apache:master Jun 16, 2022
@martin-g martin-g deleted the arrow-1876-disable-default-features-parquet branch June 17, 2022 06:00
@martin-g
Copy link
Member Author

I think I broke the build.

$ cargo +nightly build --all-features
Compiling parquet v16.0.0 (/home/martin/git/apache/arrow-rs/parquet)
error[E0432]: unresolved import `rand::thread_rng`
  --> parquet/src/util/test_common/rand_gen.rs:20:5
   |
20 |     thread_rng, Rng,
   |     ^^^^^^^^^^ no `thread_rng` in the root

error[E0433]: failed to resolve: could not find `test_util` in `util`
  --> parquet/src/util/test_common/file_util.rs:23:41
   |
23 |         PathBuf::from_str(&arrow::util::test_util::parquet_test_data()).unwrap();
   |                                         ^^^^^^^^^ could not find `test_util` in `util`

warning: unused import: `Rng`
  --> parquet/src/util/test_common/rand_gen.rs:20:17
   |
20 |     thread_rng, Rng,
   |                 ^^^
   |
   = note: `#[warn(unused_imports)]` on by default

Some errors have detailed explanations: E0432, E0433.
For more information about an error, try `rustc --explain E0432`.
warning: `parquet` (lib) generated 1 warning
error: could not compile `parquet` due to 2 previous errors; 1 warning emitted

It is interesting that the CI is green...

I will send a new PR to fix it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants