Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIRFLOW-XXXX] Increease verbosity of static checks in CI #7200

Merged
merged 1 commit into from Jan 18, 2020
Merged

[AIRFLOW-XXXX] Increease verbosity of static checks in CI #7200

merged 1 commit into from Jan 18, 2020

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jan 18, 2020 •
edited by boring-cyborg bot

The latest version of pre-commit supports showing execution times
for particular checks. This was a feature requested in
pre-commit/pre-commit#1144 and they
finally implemented it after long time saying "no" :).

This commit enables it with --verbose flag - which is also useful
as it shows hook ids and some extra information printed by
some plugins.

Issue link: Document only change, no JIRA issue

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@potiuk potiuk requested a review from mik-laj January 18, 2020 08:42
@potiuk
Copy link
Member Author

potiuk commented Jan 18, 2020

@tooptoop4 -> here you are.

@potiuk
[AIRFLOW-XXXX] Increease verbosity of static checks in CI
fa3ee76 
The latest version of pre-commit supports showing execution times
for particular checks. This was a feature requested in
pre-commit/pre-commit#1144 and they
finally implemented it after long time saying "no" :).

This commit enables it with --verbose flag - which is also useful
as it shows hook ids and some extra information printed by
some plugins.
@potiuk potiuk force-pushed the AIRFLOW-XXXX-increase-verbosity-of-static-checks branch from fc7bc8e to fa3ee76 Compare January 18, 2020 11:44
@codecov-io
Copy link

Codecov Report

Merging #7200 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7200      +/-   ##
==========================================
+ Coverage   85.41%   85.42%   +0.01%     
==========================================
  Files         753      753              
  Lines       39685    39747      +62     
==========================================
+ Hits        33898    33955      +57     
- Misses       5787     5792       +5
Impacted Files Coverage Δ
airflow/providers/amazon/aws/sensors/emr_base.py 93.61% <0%> (-6.39%) ⬇️
...rflow/providers/amazon/aws/sensors/emr_job_flow.py 95% <0%> (-0.46%) ⬇️
airflow/cli/commands/dag_command.py 85.9% <0%> (-0.31%) ⬇️
airflow/providers/amazon/aws/sensors/emr_step.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5abce47...fa3ee76. Read the comment docs.

@potiuk potiuk merged commit c5e4862 into apache:master Jan 18, 2020
potiuk added a commit that referenced this pull request Jan 21, 2020
@potiuk
[AIRFLOW-XXXX] Increease verbosity of static checks in CI (#7200)
626a417 
The latest version of pre-commit supports showing execution times
for particular checks. This was a feature requested in
pre-commit/pre-commit#1144 and they
finally implemented it after long time saying "no" :).

This commit enables it with --verbose flag - which is also useful
as it shows hook ids and some extra information printed by
some plugins.

(cherry picked from commit c5e4862)
kaxil pushed a commit that referenced this pull request Jan 22, 2020
@potiuk @kaxil
[AIRFLOW-XXXX] Increease verbosity of static checks in CI (#7200)
457f53b 
The latest version of pre-commit supports showing execution times
for particular checks. This was a feature requested in
pre-commit/pre-commit#1144 and they
finally implemented it after long time saying "no" :).

This commit enables it with --verbose flag - which is also useful
as it shows hook ids and some extra information printed by
some plugins.

(cherry picked from commit c5e4862)
kaxil pushed a commit that referenced this pull request Jan 23, 2020
@potiuk @kaxil
[AIRFLOW-XXXX] Increease verbosity of static checks in CI (#7200)
e62e44d 
The latest version of pre-commit supports showing execution times
for particular checks. This was a feature requested in
pre-commit/pre-commit#1144 and they
finally implemented it after long time saying "no" :).

This commit enables it with --verbose flag - which is also useful
as it shows hook ids and some extra information printed by
some plugins.

(cherry picked from commit c5e4862)
potiuk added a commit that referenced this pull request Jan 26, 2020
@potiuk
[AIRFLOW-XXXX] Increease verbosity of static checks in CI (#7200)
a018593 
The latest version of pre-commit supports showing execution times
for particular checks. This was a feature requested in
pre-commit/pre-commit#1144 and they
finally implemented it after long time saying "no" :).

This commit enables it with --verbose flag - which is also useful
as it shows hook ids and some extra information printed by
some plugins.

(cherry picked from commit c5e4862)
kaxil pushed a commit that referenced this pull request Jan 26, 2020
@potiuk @kaxil
[AIRFLOW-XXXX] Increease verbosity of static checks in CI (#7200)
2969e50 
The latest version of pre-commit supports showing execution times
for particular checks. This was a feature requested in
pre-commit/pre-commit#1144 and they
finally implemented it after long time saying "no" :).

This commit enables it with --verbose flag - which is also useful
as it shows hook ids and some extra information printed by
some plugins.

(cherry picked from commit c5e4862)
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
@potiuk @galuszkak
[AIRFLOW-XXXX] Increease verbosity of static checks in CI (apache#7200)
4ebaeb5 
The latest version of pre-commit supports showing execution times
for particular checks. This was a feature requested in
pre-commit/pre-commit#1144 and they
finally implemented it after long time saying "no" :).

This commit enables it with --verbose flag - which is also useful
as it shows hook ids and some extra information printed by
some plugins.
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 30, 2020
@potiuk @kaxil
[AIRFLOW-XXXX] Increease verbosity of static checks in CI (apache#7200)
03c9322 
The latest version of pre-commit supports showing execution times
for particular checks. This was a feature requested in
pre-commit/pre-commit#1144 and they
finally implemented it after long time saying "no" :).

This commit enables it with --verbose flag - which is also useful
as it shows hook ids and some extra information printed by
some plugins.

(cherry picked from commit c5e4862)
(cherry picked from commit 2969e50)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feluelle feluelle feluelle approved these changes

@mik-laj mik-laj Awaiting requested review from mik-laj

@turbaszek turbaszek Awaiting requested review from turbaszek

@BasPH BasPH Awaiting requested review from BasPH

Assignees
No one assigned
Labels
area:dev-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@potiuk @codecov-io @feluelle