Skip to content

Commit

Permalink
[AIRFLOW-XXXX] Increease verbosity of static checks in CI (apache#7200)
Browse files Browse the repository at this point in the history
The latest version of pre-commit supports showing execution times
for particular checks. This was a feature requested in
pre-commit/pre-commit#1144 and they
finally implemented it after long time saying "no" :).

This commit enables it with --verbose flag - which is also useful
as it shows hook ids and some extra information printed by
some plugins.

(cherry picked from commit c5e4862)
(cherry picked from commit 2969e50)
  • Loading branch information
potiuk authored and kaxil committed Mar 29, 2020
1 parent 29da753 commit 03c9322
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions .rat-excludes
Expand Up @@ -4,6 +4,7 @@
.github/*
.gitignore
.gitattributes
.airflow_db_initialised
.airflowignore
.coverage
.coveragerc
Expand Down
2 changes: 1 addition & 1 deletion scripts/ci/ci_run_all_static_tests.sh
Expand Up @@ -44,6 +44,6 @@ rebuild_ci_image_if_needed
IMAGES_TO_CHECK=("CI")
export IMAGES_TO_CHECK

pre-commit run --all-files --show-diff-on-failure
pre-commit run --all-files --show-diff-on-failure --verbose

script_end
4 changes: 3 additions & 1 deletion scripts/ci/pre_commit_check_license.sh
Expand Up @@ -22,4 +22,6 @@ MY_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
export FORCE_ANSWER_TO_QUESTIONS=${FORCE_ANSWER_TO_QUESTIONS:="quit"}
export REMEMBER_LAST_ANSWER="true"

"${MY_DIR}/ci_check_license.sh"
# Hide lines between ****/**** (detailed list of files)
"${MY_DIR}/ci_check_license.sh" 2>&1 | \
sed "/Files with Apache License headers will be marked AL.*$/,/^\**$/d"

0 comments on commit 03c9322

Please sign in to comment.