Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify pip version via github URL in Docker/CI workflow #28697

Merged
merged 1 commit into from Jan 5, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jan 3, 2023

We've only supported installing pip from released packages with a version number, but since pip does not support RC candidates (as extensively discussed in pypa/pip#10882) we cannot use the pip RC versions to do that.

We still want to help pip maintainers and be able to test the versions they release as early as possible, so we add support to install pip in our toolchain from a GitHub URL.

That will allow us to test new pip version as soon as designated branch of pip will contain something resembling a release candidate ready for testing.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools area:production-image Production image improvements and fixes labels Jan 3, 2023
@potiuk potiuk requested a review from uranusjr January 3, 2023 17:14
@potiuk potiuk mentioned this pull request Jan 3, 2023
@potiuk potiuk force-pushed the allow-github-url-installation-for-pip branch 2 times, most recently from 33c1a61 to 31f88a7 Compare January 4, 2023 00:34
@potiuk
Copy link
Member Author

potiuk commented Jan 4, 2023

Would love to merge that one to be able to test pip 23.0 before it gets released.

Dockerfile Outdated Show resolved Hide resolved
We've only supported to install `pip` from released packages with
a version number, but since `pip` does not support RC candidates
(as extensively discussed in pypa/pip#10882)
we cannot use the release versions to do that.

We still want to help `pip` maintainers and be able to test the versions
they release as early as possible, so we add support to install
`pip` in our toolchain from a GitHub URL.

That will allow us to test new `pip` version as soon as designated
branch of `pip` will contain something resembling a release candidate
ready for testing.
@potiuk potiuk force-pushed the allow-github-url-installation-for-pip branch from 31f88a7 to 72added Compare January 4, 2023 23:15
@potiuk potiuk merged commit 6cbf9b6 into apache:main Jan 5, 2023
@potiuk potiuk deleted the allow-github-url-installation-for-pip branch January 5, 2023 10:31
ephraimbuddy pushed a commit that referenced this pull request Jan 12, 2023
…28697)

We've only supported to install `pip` from released packages with
a version number, but since `pip` does not support RC candidates
(as extensively discussed in pypa/pip#10882)
we cannot use the release versions to do that.

We still want to help `pip` maintainers and be able to test the versions
they release as early as possible, so we add support to install
`pip` in our toolchain from a GitHub URL.

That will allow us to test new `pip` version as soon as designated
branch of `pip` will contain something resembling a release candidate
ready for testing.

(cherry picked from commit 6cbf9b6)
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 13, 2023
@ephraimbuddy ephraimbuddy added this to the Airflow 2.5.1 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools area:production-image Production image improvements and fixes changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants