Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 23.0 #11690

Closed
pradyunsg opened this issue Jan 3, 2023 · 13 comments
Closed

Release 23.0 #11690

pradyunsg opened this issue Jan 3, 2023 · 13 comments
Assignees
Labels
type: maintenance Related to Development and Maintenance Processes
Milestone

Comments

@pradyunsg
Copy link
Member

No description provided.

@pradyunsg pradyunsg added the type: maintenance Related to Development and Maintenance Processes label Jan 3, 2023
@pradyunsg
Copy link
Member Author

Well, happy new year folks!

We're due to make a release this month and, well, it seems like we do have a bundle of changes that we'd want to ship out. :)

As usual, any takers for the RM role? I'm happy to pick that up, if no one else has bandwidth.

@pradyunsg pradyunsg added this to the 23.0 milestone Jan 3, 2023
@pradyunsg pradyunsg pinned this issue Jan 3, 2023
@potiuk
Copy link
Contributor

potiuk commented Jan 3, 2023

I guess as a user I cannot help with the release, but I can offer help in testing the release in Apache Airflow case.

We have quite a few cases and one of the most complex dependency mechanisms out there and as long as some version is in the state that is ready to "test" - happy to test it there.

I know (after the discussion in #10882) that pip maintainers are not in favour of release candidates, but if there is time where you can say "here the branch or tags is ready to test" I just opened a PR modifying our CI framework to allow for "github URL" installation mechanism for pip in our toolchain in Apache Airflow:

apache/airflow#28697

As long as there is something "ready" to test I will watch this issue and will be happy to run it through the full set of tests.

I could also do that in main and even run our toolchain daily or weekly or whatever, but I am not sure if this is in any way actionable - not sure if you would like to be flooded by "main" issues which are just a byproduct of being main and possibly containing known issues.

With the above modifications merged I could also run tests with your main as regularly as you think makes sense - just let me know - I'd love to help pip testing in whatever way Airflow can help, since we are very heavy users and I think we are utilsing quite a lot of pip capabilities and complexities, so this might be helpful also for you - especially that it will be run on Airflow's resources and I might be doing pre-vetting of those problems to see if they are "worthy" of reporting.

Just to show an example how it can be helpful - because of our big number of dependencies, we've been successfully doing this for other projects that we depend on and it helped those project by us (myself as I am mostly on a watch there) quickly catching and reporting issues like that that our "canary" runs on CI detected pretty much immediately after they were released (but we've never been doing it for main for them):

Examples:

@pradyunsg pradyunsg self-assigned this Jan 9, 2023
@pradyunsg
Copy link
Member Author

Alrighty, no one said anything over the last few days so I'll self-assign myself. :)

@dnicolodi
Copy link
Contributor

@pradyunsg I would be happy to help. Please let me know if there is anything I can do to help with in preparing the release.

@pradyunsg pradyunsg mentioned this issue Jan 23, 2023
1 task
@pradyunsg
Copy link
Member Author

Hold off on merging things today folks; I'll be cutting a release in ~8 hours.

@dnicolodi
Copy link
Contributor

@pradyunsg Can you please consider merging #11740 before the release? I would very much like to do not have pip broken on Debian till the next release in a few months. Thank you very much!

This was referenced Jan 30, 2023
@pradyunsg
Copy link
Member Author

pradyunsg commented Jan 30, 2023

@pradyunsg
Copy link
Member Author

@dnicolodi
Copy link
Contributor

That would be great. Although it may be worth to investigate #11770. I haven't had time to try to reproduce it and given my tests on Debian, I'm not so sure anymore that the issue fixed in #11740 is the cause of the errors reported there. I can try to find some time to have a look. Of course, one possibility is to have a bugfix release now, and another one in the close feature if #11170 turns out to require one.

@pfmoore
Copy link
Member

pfmoore commented Feb 6, 2023

+1 from me.

-1 on hanging round for #11770 to be investigated. If no-one has already done any work on fixing that issue (or validating the issue is fixed by #11740) my view is that it's not urgent enough to wait. Whether we follow up with a second bugfix release depends (again IMO) on (1) whether any other bugs have been fixed in the meantime, and (2) how many bug fixes the RM thinks are required to warrant a further release.

@pradyunsg
Copy link
Member Author

pradyunsg commented Feb 15, 2023

I'll be cutting a release today evening (6-8 hours from now).

Update: life got in the way. Going to try again later.

@pradyunsg
Copy link
Member Author

And, 23.0.1 is up.

I'm gonna say that's all for this cycle unless something bad happens in the next ~24 hours with this bugfix. :)

@pradyunsg
Copy link
Member Author

pradyunsg commented Feb 19, 2023

And, no new issues. Thanks everyone! ^.^

@pradyunsg pradyunsg unpinned this issue Feb 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

No branches or pull requests

4 participants