Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back http provider after requests removes LGPL dependency #16974

Merged
merged 1 commit into from Jul 13, 2021

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jul 13, 2021

Following merging the psf/requests#5797
and requests 2.26.0 release without LGPL chardet dependency,
we can now bring back http as pre-installed provider as it does
not bring chardet automatically any more.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Following merging the psf/requests#5797
and requests 2.26.0 release without LGPL chardet dependency,
we can now bring back http as pre-installed provider as it does
not bring chardet automatically any more.
@potiuk potiuk force-pushed the bring-back-mandatory-http-provider branch from c0e0b45 to 6b81adf Compare July 13, 2021 18:55
@potiuk
Copy link
Member Author

potiuk commented Jul 13, 2021

Seems ready to go :)

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jul 13, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit c46e841 into apache:main Jul 13, 2021
@potiuk potiuk deleted the bring-back-mandatory-http-provider branch July 13, 2021 20:13
@ashb ashb added this to the Airflow 2.1.3 milestone Jul 14, 2021
josh-fell pushed a commit to josh-fell/airflow that referenced this pull request Jul 19, 2021
…che#16974)

Following merging the psf/requests#5797
and requests 2.26.0 release without LGPL chardet dependency,
we can now bring back http as pre-installed provider as it does
not bring chardet automatically any more.
potiuk added a commit to potiuk/airflow that referenced this pull request Aug 2, 2021
…che#16974)

Following merging the psf/requests#5797
and requests 2.26.0 release without LGPL chardet dependency,
we can now bring back http as pre-installed provider as it does
not bring chardet automatically any more.

(cherry picked from commit c46e841)
potiuk added a commit to potiuk/airflow that referenced this pull request Aug 5, 2021
…che#16974)

Following merging the psf/requests#5797
and requests 2.26.0 release without LGPL chardet dependency,
we can now bring back http as pre-installed provider as it does
not bring chardet automatically any more.

(cherry picked from commit c46e841)
kaxil added a commit to astronomer/airflow that referenced this pull request Aug 13, 2021
Since apache#16974 we have switched back to including HTTP provider and this comment now is not correct.
kaxil added a commit that referenced this pull request Aug 13, 2021
Since #16974 we have switched back to including HTTP provider and this comment now is not correct.
kaxil pushed a commit that referenced this pull request Aug 17, 2021
)

Following merging the psf/requests#5797
and requests 2.26.0 release without LGPL chardet dependency,
we can now bring back http as pre-installed provider as it does
not bring chardet automatically any more.

(cherry picked from commit c46e841)
jhtimmins pushed a commit that referenced this pull request Aug 17, 2021
)

Following merging the psf/requests#5797
and requests 2.26.0 release without LGPL chardet dependency,
we can now bring back http as pre-installed provider as it does
not bring chardet automatically any more.

(cherry picked from commit c46e841)
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Mar 10, 2022
Since apache/airflow#16974 we have switched back to including HTTP provider and this comment now is not correct.

GitOrigin-RevId: f2a8a73ca99912d25e9cd8142038cf3a6df622d6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 4, 2022
Since apache/airflow#16974 we have switched back to including HTTP provider and this comment now is not correct.

GitOrigin-RevId: f2a8a73ca99912d25e9cd8142038cf3a6df622d6
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 10, 2022
Since apache/airflow#16974 we have switched back to including HTTP provider and this comment now is not correct.

GitOrigin-RevId: f2a8a73ca99912d25e9cd8142038cf3a6df622d6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Aug 27, 2022
Since apache/airflow#16974 we have switched back to including HTTP provider and this comment now is not correct.

GitOrigin-RevId: f2a8a73ca99912d25e9cd8142038cf3a6df622d6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 4, 2022
Since apache/airflow#16974 we have switched back to including HTTP provider and this comment now is not correct.

GitOrigin-RevId: f2a8a73ca99912d25e9cd8142038cf3a6df622d6
aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 7, 2022
Since apache/airflow#16974 we have switched back to including HTTP provider and this comment now is not correct.

GitOrigin-RevId: f2a8a73ca99912d25e9cd8142038cf3a6df622d6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Dec 7, 2022
Since apache/airflow#16974 we have switched back to including HTTP provider and this comment now is not correct.

GitOrigin-RevId: f2a8a73ca99912d25e9cd8142038cf3a6df622d6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jan 27, 2023
Since apache/airflow#16974 we have switched back to including HTTP provider and this comment now is not correct.

GitOrigin-RevId: f2a8a73ca99912d25e9cd8142038cf3a6df622d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge kind:documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to latest requests when it is released without chardet dependency
3 participants