Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to latest requests when it is released without chardet dependency #16929

Closed
potiuk opened this issue Jul 11, 2021 · 3 comments · Fixed by #16974
Closed

Upgrade to latest requests when it is released without chardet dependency #16929

potiuk opened this issue Jul 11, 2021 · 3 comments · Fixed by #16974
Assignees
@potiuk
Labels
kind:bug This is a clearly a bug

Comments

@potiuk
Copy link
Member

potiuk commented Jul 11, 2021

As discussed at length in https://issues.apache.org/jira/browse/LEGAL-572 we found out that the chardet library used by requests library was a mandatory dependency to requests and since it has LGPL licence, we should not release any Apache Software with it.

Since then (and since in Airflow we rely on requests heavily) we have been working with the requests maintainers and "charset-normalizer" maintainer to make it possible to replace chardet with MIT-licensed charset-normalizer instead so that requests library can be used in Python releases by Apache projects.

This was a bumpy road but finally the PR by @ashb has been merged: psf/requests#5797 and we hope soon a new version of requests library will be released.

Once the new release is ready we should bump to the new version and we should help with testing when RC is available.
@potiuk potiuk added the kind:bug This is a clearly a bug label Jul 11, 2021
@potiuk potiuk self-assigned this Jul 11, 2021
@potiuk potiuk mentioned this issue Jul 11, 2021
Merged
@uranusjr
Copy link
Member

Did #16974 resolve this?

@potiuk
Copy link
Member Author

potiuk commented Jul 14, 2021

oh yeah

@potiuk potiuk closed this as completed Jul 14, 2021
@potiuk potiuk linked a pull request Jul 14, 2021 that will close this issue
Switch back http provider after requests removes LGPL dependency #16974
Merged
@potiuk
Copy link
Member Author

potiuk commented Jul 14, 2021 •
edited

New requests 2.26.0 released and we switched to it ! Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@potiuk potiuk

Labels
kind:bug This is a clearly a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch back http provider after requests removes LGPL dependency potiuk/airflow
2 participants
@potiuk @uranusjr