Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-https elasticsearch external links #16489

Merged
merged 1 commit into from Jun 16, 2021

Conversation

jedcunningham
Copy link
Member

Support non-https elasticsearch external links.

Also provide an example for frontend as its not immediately apparent how to build a short(ish) deep link.

Also provide an example for `frontend` as its not immediately apparent
how to build a short(ish) deep link.
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jun 16, 2021
@kaxil kaxil merged commit 3cf67be into apache:main Jun 16, 2021
@kaxil kaxil deleted the elasticsearch_non_https_frontend branch June 16, 2021 21:44
@NiklasBeierl
Copy link

Heyya,

I really need this fix on one of my deployments. But I can't find the release where it was included. Can someone shed light on that?

@potiuk
Copy link
Member

potiuk commented Nov 29, 2021

#16456

@NiklasBeierl
Copy link

NiklasBeierl commented Nov 29, 2021

#16456

Hey @potiuk, thanks for the reply!

I think I get the gist of the issue you are linking. I guess you where trying to figure out what PRs should be included in a release? And it seems like this PR was included there. However, I can't figure out which release this issue refers to. Can you give me an airflow version?

@potiuk
Copy link
Member

potiuk commented Nov 29, 2021

It's not released in "version" of airlfow but in elastisearch version of provider:

Screenshot from 2021-11-29 17-55-48

It's just accidental that certain versions of airflow are using the latest relesed version of providers when they are released. You are free to install providers separately from Airflow at your will https://airflow.apache.org/docs/apache-airflow/stable/installation/installing-from-pypi.html#installation-and-upgrading-of-airflow-providers-separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logging area:providers full tests needed We need to run full set of tests for this PR to merge kind:documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants