Avoid chicken-egg situation with ES Provider and Airflow 2.1.1 #16488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR avoids chicken-egg situation; if Airflow 2.1.1 is released first
it will fail when using ES logging with following error:
```
Unable to load the config, contains a configuration error.
Traceback (most recent call last):
File "/usr/local/lib/python3.7/logging/config.py", line 563, in configure
handler = self.configure_handler(handlers[name])
File "/usr/local/lib/python3.7/logging/config.py", line 736, in configure_handler
result = factory(**kwargs)
TypeError: __init__() got an unexpected keyword argument 'host_field'
```
This is because this will be added in soon to be released ES provider 2.0.1.
So `apache-airflow[elasticsearch]==2.1.1` needs `'apache-airflow-providers-elasticsearch>=2.0.1'`
We can avoid the need for this if we release the provider earlier. In which case we can close
this PR.
|
Can we not detect the provider’s version? Using inspect like this makes me a bit worried since it tends to cause problems in the long term. |
|
We don't need this PR anymore, ES Provider is ready to be released as soon as we merge: #16489 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids chicken-egg situation; if Airflow 2.1.1 is released first
it will fail when using ES logging with following error:
This is because this will be added in soon to be released ES provider 2.0.1.
So
apache-airflow[elasticsearch]==2.1.1needs'apache-airflow-providers-elasticsearch>=2.0.1'We can avoid the need for this if we release the provider earlier. In which case we can close
this PR.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.