Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type definition optimization & add key for useModal #39701

Merged
merged 5 commits into from Dec 21, 2022
Merged

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Dec 21, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

1. 给 useModal 加了唯一 key

Language Changelog
🇺🇸 English fix: add key for useModal
🇨🇳 Chinese fix: add key for useModal

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2022

size-limit report 📦

Path Size
./dist/antd.min.js 377.41 KB (+4 B 🔺)
./dist/antd-with-locales.min.js 432.71 KB (+6 B 🔺)

@li-jia-nan
Copy link
Member Author

突然想到 React.ReactNode 类型可能会对用户造成 break change,改回 ReactElement

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (a1a55c2) compared to base (d93bca1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #39701   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          556       556           
  Lines         9605      9605           
  Branches      2717      2717           
=========================================
  Hits          9605      9605           
Impacted Files Coverage Δ
components/message/useMessage.tsx 100.00% <100.00%> (ø)
components/modal/useModal/index.tsx 100.00% <100.00%> (ø)
components/notification/useNotification.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yoyo837 yoyo837 merged commit b35fbcf into master Dec 21, 2022
@yoyo837 yoyo837 deleted the addkey branch December 21, 2022 06:39
@vagusX vagusX mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants