Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: App "two children with the same key" warning #39695

Merged
merged 1 commit into from Dec 21, 2022

Conversation

Kamahl19
Copy link
Contributor

@Kamahl19 Kamahl19 commented Dec 20, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #39694

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Application fix warning about two children with the same key.
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

  • 🚨 Please fill changelog in the PR

    • Write with a developer-oriented perspective and narrative method, without describing the details of the repair
    • Describing the problem and the impact on the developer
    • describing the user-first site problem, not your solution
    • Refer: https://ant.design/changelog#501
  • 🚨 请填写 PR 中的 changelog

    • 请用面向开发者的角度叙述方式撰写,不描述修复细节
    • 描述问题和对开发者的影响
    • 描述用户第一现场的问题,而非你的解决方式
    • 参考:https://ant.design/changelog-cn#501

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2022

@Kamahl19 Kamahl19 changed the title #39694 Fix "two children with the same key" warning when using <App /> fix: App "two children with the same key" warning Dec 20, 2022
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (06d947c) compared to base (d43b8e7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #39695   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          556       556           
  Lines         9605      9605           
  Branches      2717      2717           
=========================================
  Hits          9605      9605           
Impacted Files Coverage Δ
components/message/useMessage.tsx 100.00% <100.00%> (ø)
components/notification/useNotification.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yoyo837 yoyo837 merged commit d93bca1 into ant-design:master Dec 21, 2022
@li-jia-nan
Copy link
Member

li-jia-nan commented Dec 21, 2022

@yoyo837 是不是可以顺便给 useModal 也加上 key?

@li-jia-nan
Copy link
Member

我来加吧

@li-jia-nan
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App component triggers "two children with the same key" warning
3 participants