Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Select virtual=false will bind to real element for a11y #39550

Merged
merged 4 commits into from Dec 14, 2022
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 14, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

resolve #39199

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Optimize Select a11y to bind real option element when virtual=false.
🇨🇳 Chinese 优化 Select 无障碍体验,当 virtual=false 时,将会绑定无障碍访问到实际选项元素上。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2022

size-limit report 📦

Path Size
./dist/antd.min.js 373.49 KB (+61 B 🔺)
./dist/antd-with-locales.min.js 426.94 KB (+57 B 🔺)

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (4e46499) compared to base (9e25a81).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #39550   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          546       546           
  Lines         9363      9363           
  Branches      2653      2653           
=========================================
  Hits          9363      9363           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ zombieJ merged commit 0fffe06 into master Dec 14, 2022
@zombieJ zombieJ deleted the a11y branch December 14, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility issues with the Select component
2 participants