Skip to content

Commit

Permalink
chore: Select virtual=false will bind to real element for a11y (#39550
Browse files Browse the repository at this point in the history
)

* chore: bump rc-select

* docs: update doc

* test: Update snapshot

* test: Update snapshot
  • Loading branch information
zombieJ committed Dec 14, 2022
1 parent 3d627eb commit 0fffe06
Show file tree
Hide file tree
Showing 9 changed files with 287 additions and 526 deletions.
110 changes: 68 additions & 42 deletions components/calendar/__tests__/__snapshots__/demo-extend.test.ts.snap

Large diffs are not rendered by default.

Expand Up @@ -24931,25 +24931,6 @@ exports[`ConfigProvider components Select configProvider virtual and dropdownMat
style="opacity: 0; min-width: 0;"
>
<div>
<div
id="rc_select_TEST_OR_SSR_list"
role="listbox"
style="height: 0px; width: 0px; overflow: hidden;"
>
<div
aria-selected="false"
id="rc_select_TEST_OR_SSR_list_0"
role="presentation"
/>
<div
aria-label="Light"
aria-selected="false"
id="rc_select_TEST_OR_SSR_list_1"
role="option"
>
Bamboo
</div>
</div>
<div
class="rc-virtual-list"
style="position: relative;"
Expand All @@ -24961,6 +24942,8 @@ exports[`ConfigProvider components Select configProvider virtual and dropdownMat
<div>
<div
class="rc-virtual-list-holder-inner"
id="rc_select_TEST_OR_SSR_list"
role="listbox"
style="display: flex; flex-direction: column;"
>
<div
Expand All @@ -24972,6 +24955,8 @@ exports[`ConfigProvider components Select configProvider virtual and dropdownMat
<div
aria-selected="false"
class="ant-select-item ant-select-item-option ant-select-item-option-grouped ant-select-item-option-active"
id="rc_select_TEST_OR_SSR_list_1"
role="option"
title="Light"
>
<div
Expand Down
32 changes: 10 additions & 22 deletions components/list/__tests__/__snapshots__/pagination.test.tsx.snap
Expand Up @@ -396,28 +396,6 @@ exports[`List.pagination should change page size work 2`] = `
style="min-width: 0; opacity: 0;"
>
<div>
<div
id="rc_select_TEST_OR_SSR_list"
role="listbox"
style="height: 0px; width: 0px; overflow: hidden;"
>
<div
aria-label="10 / page"
aria-selected="false"
id="rc_select_TEST_OR_SSR_list_0"
role="option"
>
10
</div>
<div
aria-label="20 / page"
aria-selected="false"
id="rc_select_TEST_OR_SSR_list_1"
role="option"
>
20
</div>
</div>
<div
class="rc-virtual-list"
style="position: relative;"
Expand All @@ -429,11 +407,15 @@ exports[`List.pagination should change page size work 2`] = `
<div>
<div
class="rc-virtual-list-holder-inner"
id="rc_select_TEST_OR_SSR_list"
role="listbox"
style="display: flex; flex-direction: column;"
>
<div
aria-selected="false"
class="ant-select-item ant-select-item-option ant-select-item-option-active"
id="rc_select_TEST_OR_SSR_list_0"
role="option"
title="10 / page"
>
<div
Expand All @@ -451,6 +433,8 @@ exports[`List.pagination should change page size work 2`] = `
<div
aria-selected="false"
class="ant-select-item ant-select-item-option"
id="rc_select_TEST_OR_SSR_list_1"
role="option"
title="20 / page"
>
<div
Expand All @@ -468,6 +452,8 @@ exports[`List.pagination should change page size work 2`] = `
<div
aria-selected="true"
class="ant-select-item ant-select-item-option ant-select-item-option-selected"
id="rc_select_TEST_OR_SSR_list_2"
role="option"
title="50 / page"
>
<div
Expand All @@ -485,6 +471,8 @@ exports[`List.pagination should change page size work 2`] = `
<div
aria-selected="false"
class="ant-select-item ant-select-item-option"
id="rc_select_TEST_OR_SSR_list_3"
role="option"
title="100 / page"
>
<div
Expand Down

0 comments on commit 0fffe06

Please sign in to comment.