feat : new components app #39046
Merged
feat : new components app #39046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zombieJ
reviewed
Nov 28, 2022
zombieJ
reviewed
Nov 28, 2022
zombieJ
reviewed
Nov 28, 2022
zombieJ
reviewed
Nov 29, 2022
codeball-ai-writer
bot
added
codeball:needs-careful-review
and removed
codeball:needs-review
labels
zombieJ
reviewed
Nov 29, 2022
MadCcc
reviewed
Nov 30, 2022
MadCcc
reviewed
Nov 30, 2022
afc163
reviewed
Nov 30, 2022
afc163
reviewed
Nov 30, 2022
afc163
reviewed
Nov 30, 2022
afc163
reviewed
Nov 30, 2022
afc163
reviewed
Nov 30, 2022
afc163
reviewed
Nov 30, 2022
afc163
reviewed
Nov 30, 2022
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## feature #39046 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 548 550 +2
Lines 9407 9424 +17
Branches 2675 2676 +1
=========================================
+ Hits 9407 9424 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
字号和行高影响 demo 了，一会再看看 |
|
看样子是纠正了一波 image snapshot，approve 了 |
MadCcc
reviewed
Dec 5, 2022
heiyu4585
force-pushed
the
app-feature
branch
from
26ece61
to
03cfdd1
Compare
|
ci 怎么没跑？ |
我也在纳闷 - -!,可能是我rebase的原因 |
Co-authored-by: afc163 <afc163@gmail.com>
heiyu4585
force-pushed
the
app-feature
branch
from
187c9ce
to
d05884f
Compare
MadCcc
approved these changes
Dec 6, 2022
afc163
reviewed
Dec 6, 2022
| @@ -0,0 +1,7 @@ | |||
| ## zh-CN | |||
|
|
|||
| 获取 `message` 静态方法. | |||
There was a problem hiding this comment.
找个地方写一下这种方式和 useMessage 的差异是啥？前提是啥，好处是啥？
afc163
reviewed
Dec 6, 2022
| @@ -0,0 +1,7 @@ | |||
| ## zh-CN | |||
|
|
|||
| 获取 `notification` 静态方法. | |||
There was a problem hiding this comment.
Suggested change
| 获取 `notification` 静态方法. | |
| 获取 `notification` 静态方法。 |
afc163
reviewed
Dec 6, 2022
|
对于一些非 hooks 就无法使用全局的样式，比如 axios 封装中使用 message 的时候，当动态切换了主题的情况下，这个 message 仍旧会是默认的浅色。这种情况怎么解决？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
#38901
📝 Changelog
☑️ Self-Check before Merge