Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update app demo #39347

Merged
merged 19 commits into from Dec 14, 2022
Merged

feat: update app demo #39347

merged 19 commits into from Dec 14, 2022

Conversation

heiyu4585
Copy link
Contributor

@heiyu4585 heiyu4585 commented Dec 7, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

#39046

📝 Changelog

Language Changelog
🇺🇸 English update app demo
🇨🇳 Chinese update app demo

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

components/app/demo/basic.md Outdated Show resolved Hide resolved
@afc163
Copy link
Member

afc163 commented Dec 7, 2022

  • 找个地方写一下这种方式和 useMessage 的差异是啥?前提是啥,好处是啥?本质上是说清楚为什么我们要提供这个 useApp。
  • 这个示例可能会误导用户在一个子页面或者子功能上添加 App,但这不是我们推荐的。需要写清楚 App 是给应用最外层全局包裹一次就行。
  • App 互相内嵌的时候,应该报错,提示一个应用包裹一个 App 就行。

@zombieJ
Copy link
Member

zombieJ commented Dec 7, 2022

Note:

  • App 所在层级需要描述清楚(ConfigProvider 之下才能消费 Token)
    • 成对出现描述清楚
  • App 提供的 context 位置需要讲清楚(反之的话和 useXXX 的异同点),可以给个例子
  • 内嵌使用场景(如无必要,不嵌套)
  • 提供一个示例指导如何去做全局的(rudux 场景)

@zombieJ
Copy link
Member

zombieJ commented Dec 12, 2022

截屏2022-12-12 23 49 54

这个看起来有点怪异,干脆调整一下目录:

如何使用 -> 使用事项

基础用法

App 通过 Context 提供上下文方法调用,因而 useApp 需要作为子组件才能使用。我们推荐在应用中顶层包裹 App:

// Demo 部分不变

(zombiej: 3. App.useApp 需要在 App 包裹内才可以使用. 合并到这里 ↓)
注意:App.useApp 必须在 App 之下方可使用。

与 ConfigProvider 先后顺序

如果你希望 App 的重置样式功能消费主题 token,那你必须将其放置于配置主题的 ConfigProvider 之下:

<ConfigProvider theme={{ ... }}>
  <App>
    ...
  </App>
</ConfigProvider>

@heiyu4585
Copy link
Contributor Author

截屏2022-12-12 23 49 54

这个看起来有点怪异,干脆调整一下目录:

如何使用 -> 使用事项

基础用法

App 通过 Context 提供上下文方法调用,因而 useApp 需要作为子组件才能使用。我们推荐在应用中顶层包裹 App:

// Demo 部分不变

(zombiej: 3. App.useApp 需要在 App 包裹内才可以使用. 合并到这里 ↓) 注意:App.useApp 必须在 App 之下方可使用。

与 ConfigProvider 先后顺序

如果你希望 App 的重置样式功能消费主题 token,那你必须将其放置于配置主题的 ConfigProvider 之下:

<ConfigProvider theme={{ ... }}>
  <App>
    ...
  </App>
</ConfigProvider>

done

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (809f572) compared to base (6e2a7e4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #39347   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          556       557    +1     
  Lines         9562      9593   +31     
  Branches      2711      2713    +2     
=========================================
+ Hits          9562      9593   +31     
Impacted Files Coverage Δ
components/select/index.tsx 100.00% <0.00%> (ø)
components/watermark/index.tsx 100.00% <0.00%> (ø)
components/config-provider/index.tsx 100.00% <0.00%> (ø)
components/config-provider/context.tsx 100.00% <0.00%> (ø)
components/watermark/useMutationObserver.ts 100.00% <0.00%> (ø)
components/float-button/FloatButtonGroup.tsx 100.00% <0.00%> (ø)
components/watermark/utils.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@heiyu4585 heiyu4585 merged commit 49e8c13 into ant-design:feature Dec 14, 2022
@heiyu4585 heiyu4585 deleted the feat-app branch December 22, 2022 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants