Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct theme import for Descriptions element #30602

Merged
merged 1 commit into from May 24, 2021

Conversation

lisenenkov
Copy link
Contributor

@lisenenkov lisenenkov commented May 20, 2021

With @import '../../style/themes/default'; theme customization doesn't work

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Descriptions wrong styling import.
🇨🇳 Chinese 修复 Descriptions 单独引入样式丢失的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

With @import '../../style/themes/default'; theme customization doesn't work
@github-actions
Copy link
Contributor

Prepare preview

@lisenenkov lisenenkov changed the title Correct theme import Fix: Correct theme import for Descriptions element May 20, 2021
@afc163 afc163 changed the title Fix: Correct theme import for Descriptions element fix: Correct theme import for Descriptions element May 20, 2021
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #30602 (e45104a) into master (7c06c1b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #30602   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7521      7521           
  Branches      2050      2102   +52     
=========================================
  Hits          7521      7521           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c06c1b...e45104a. Read the comment docs.

@afc163 afc163 merged commit 6b419bd into ant-design:master May 24, 2021
afc163 pushed a commit that referenced this pull request May 24, 2021
With @import '../../style/themes/default'; theme customization doesn't work
@lisenenkov lisenenkov deleted the patch-1 branch May 24, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants