Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useNotification className should work correctly #30588

Merged
merged 1 commit into from May 19, 2021

Conversation

afc163
Copy link
Member

@afc163 afc163 commented May 19, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #30576

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Notification custom styles don't apply to correct div by className when using useNotification.
🇨🇳 Chinese 修复 Notification useNotification 生成的通知框 className 作用范围不一致的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2021

@afc163 afc163 changed the title fix: useNotification className should work fix: useNotification className should work correctly May 19, 2021
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #30588 (2303a06) into master (7e5a505) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #30588   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7521      7521           
  Branches      2050      2050           
=========================================
  Hits          7521      7521           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e5a505...2303a06. Read the comment docs.

@afc163 afc163 force-pushed the fix-notification-holder-style branch from 81942d2 to 2303a06 Compare May 19, 2021 08:41
@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2021

Size Change: -57 B (0%)

Total Size: 832 kB

Filename Size Change
./dist/antd.compact.min.css 63.8 kB -23 B (0%)
./dist/antd.dark.min.css 65.1 kB -16 B (0%)
./dist/antd.min.css 63.9 kB -18 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 341 kB 0 B
./dist/antd.min.js 298 kB 0 B

compressed-size-action

@afc163 afc163 merged commit f3d5470 into master May 19, 2021
@afc163 afc163 deleted the fix-notification-holder-style branch May 19, 2021 09:31
afc163 added a commit that referenced this pull request May 24, 2021
* docs(:sparkles:): release 4.15.6 (#30562)

* fix(Collapse): end motion when set activeKey while hiding (#30555)

* docs: update changelog

* fix: Typography ellipsis flush when contain suffix (#30582)

* fix: Typography ellipsis flush when contain suffix

* update snapshot

* fix Text default rows

* fix Text default rows

* style: refactor Collapse arrow style (#30586)

close #30585

* fix: nested Table margin inside table with fixed columns (#30587)

close #30564

* fix: useNotification className should work (#30588)

close #30576

* fix: Space missing TS def (#30590)

* docs: Update Transfer asnyc table demo
close #30350

* fix: Anchor should trigger onChange when have getCurrentAnchor (#30601)

* fix: Anchor should trigger onChange when have getCurrentAnchor

close #30584

* test: add test case

* chore: Thanks @yesmeck & @ycjcl868 (#30618)

* chore(config-provider): support dynamic prefixCls (#30625)

* feat: improve Table filter and sorter position

* fix: edge cases of th border

* fix lint

* style: apply new design

* fix css detail

* fix stylelint

* fix css error

* style: sorter icon hover color

* fix test cases

* update snapshot

* fix th padding

* fix calc

Co-authored-by: JuFeng Zhang <zjffun@gmail.com>
Co-authored-by: 二货机器人 <smith3816@gmail.com>
Co-authored-by: Kermit <kermitlx@outlook.com>
Co-authored-by: chenshuai2144 <qixian.cs@outlook.com>
@afc163 afc163 mentioned this pull request May 24, 2021
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styles doesn't apply correctly on notification opened by useNotification hook
1 participant