Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use flex gap of space #30023

Merged
merged 3 commits into from
Apr 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { detectFlexGapSupported } from '../../_util/styleChecker';
import { detectFlexGapSupported } from '../styleChecker';

export default () => {
const [flexible, setFlexible] = React.useState(false);
Expand Down
2 changes: 1 addition & 1 deletion components/grid/row.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import ResponsiveObserve, {
ScreenMap,
responsiveArray,
} from '../_util/responsiveObserve';
import useFlexGapSupport from './hooks/useFlexGapSupport';
import useFlexGapSupport from '../_util/hooks/useFlexGapSupport';

const RowAligns = tuple('top', 'middle', 'bottom', 'stretch');
const RowJustify = tuple('start', 'end', 'center', 'space-around', 'space-between');
Expand Down
22 changes: 13 additions & 9 deletions components/space/Item.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,23 @@ export default function Item({
split,
wrap,
}: ItemProps) {
const { horizontalSize, verticalSize, latestIndex } = React.useContext(SpaceContext);
const { horizontalSize, verticalSize, latestIndex, supportFlexGap } = React.useContext(
SpaceContext,
);

let style: React.CSSProperties = {};

if (direction === 'vertical') {
if (index < latestIndex) {
style = { marginBottom: horizontalSize / (split ? 2 : 1) };
if (!supportFlexGap) {
if (direction === 'vertical') {
if (index < latestIndex) {
style = { marginBottom: horizontalSize / (split ? 2 : 1) };
}
} else {
style = {
...(index < latestIndex && { [marginDirection]: horizontalSize / (split ? 2 : 1) }),
...(wrap && { paddingBottom: verticalSize }),
};
}
} else {
style = {
...(index < latestIndex && { [marginDirection]: horizontalSize / (split ? 2 : 1) }),
...(wrap && { paddingBottom: verticalSize }),
};
}

if (children === null || children === undefined) {
Expand Down
55 changes: 55 additions & 0 deletions components/space/__tests__/__snapshots__/demo.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,61 @@ exports[`renders ./components/space/demo/debug.md correctly 1`] = `
</div>
`;

exports[`renders ./components/space/demo/gap-in-line.md correctly 1`] = `
Array [
<button
aria-checked="false"
class="ant-switch"
role="switch"
type="button"
>
<div
class="ant-switch-handle"
/>
<span
class="ant-switch-inner"
/>
</button>,
<div
class="ant-space ant-space-horizontal ant-space-align-center"
style="flex-wrap:wrap;margin-bottom:-8px;width:310px;background:blue"
>
<div
class="ant-space-item"
style="margin-right:8px;padding-bottom:8px"
>
<div
style="width:150px;height:100px;background:red"
/>
</div>
<div
class="ant-space-item"
style="margin-right:8px;padding-bottom:8px"
>
<div
style="width:150px;height:100px;background:red"
/>
</div>
<div
class="ant-space-item"
style="margin-right:8px;padding-bottom:8px"
>
<div
style="width:150px;height:100px;background:red"
/>
</div>
<div
class="ant-space-item"
style="padding-bottom:8px"
>
<div
style="width:150px;height:100px;background:red"
/>
</div>
</div>,
]
`;

exports[`renders ./components/space/demo/size.md correctly 1`] = `
Array [
<div
Expand Down
48 changes: 48 additions & 0 deletions components/space/demo/gap-in-line.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
---
order: 99
title:
zh-CN: Flex gap 样式
en-US: Flex gap style
debug: true
---

## zh-CN

Debug usage

## en-US

Debug usage

```tsx
import { Space, Switch } from 'antd';

const style: React.CSSProperties = {
width: 150,
height: 100,
background: 'red',
};

const Demo = () => {
const [singleCol, setSingleCol] = React.useState(false);

return (
<>
<Switch
checked={singleCol}
onChange={() => {
setSingleCol(!singleCol);
}}
/>
<Space style={{ width: singleCol ? 307 : 310, background: 'blue' }} size={[8, 8]} wrap>
<div style={style} />
<div style={style} />
<div style={style} />
<div style={style} />
</Space>
</>
);
};

ReactDOM.render(<Demo />, mountNode);
```
29 changes: 22 additions & 7 deletions components/space/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@ import toArray from 'rc-util/lib/Children/toArray';
import { ConfigContext } from '../config-provider';
import { SizeType } from '../config-provider/SizeContext';
import Item from './Item';
import useFlexGapSupport from '../_util/hooks/useFlexGapSupport';

export const SpaceContext = React.createContext({
latestIndex: 0,
horizontalSize: 0,
verticalSize: 0,
supportFlexGap: false,
});

export type SpaceSize = SizeType | number;
Expand Down Expand Up @@ -51,6 +53,8 @@ const Space: React.FC<SpaceProps> = props => {
...otherProps
} = props;

const supportFlexGap = useFlexGapSupport();

const [horizontalSize, verticalSize] = React.useMemo(
() =>
((Array.isArray(size) ? size : [size, size]) as [SpaceSize, SpaceSize]).map(item =>
Expand All @@ -61,10 +65,6 @@ const Space: React.FC<SpaceProps> = props => {

const childNodes = toArray(children, { keepEmpty: true });

if (childNodes.length === 0) {
return null;
}

const mergedAlign = align === undefined && direction === 'horizontal' ? 'center' : align;
const prefixCls = getPrefixCls('space', customizePrefixCls);
const cn = classNames(
Expand Down Expand Up @@ -105,18 +105,33 @@ const Space: React.FC<SpaceProps> = props => {
/* eslint-enable */
});

const spaceContext = React.useMemo(
() => ({ horizontalSize, verticalSize, latestIndex, supportFlexGap }),
[horizontalSize, verticalSize, latestIndex, supportFlexGap],
);

// =========================== Render ===========================
if (childNodes.length === 0) {
return null;
}

const gapStyle: React.CSSProperties = {};
if (supportFlexGap) {
gapStyle.columnGap = horizontalSize;
gapStyle.rowGap = verticalSize;
}

return (
<div
className={cn}
style={{
...gapStyle,
...(wrap && { flexWrap: 'wrap', marginBottom: -verticalSize }),
...style,
}}
{...otherProps}
>
<SpaceContext.Provider value={{ horizontalSize, verticalSize, latestIndex }}>
{nodes}
</SpaceContext.Provider>
<SpaceContext.Provider value={spaceContext}>{nodes}</SpaceContext.Provider>
</div>
);
};
Expand Down