Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use flex gap of space #30023

Merged
merged 3 commits into from Apr 6, 2021
Merged

fix: Use flex gap of space #30023

merged 3 commits into from Apr 6, 2021

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 5, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #29868

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Refactor Space that use flexGap style instead of margin to fix some layout edge case.
🇨🇳 Chinese 改写 Space 使用 flexGap 以代替 margin 样式以处理某些边界情况下的布局问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@zombieJ zombieJ requested a review from afc163 April 5, 2021 07:13
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2021

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #30023 (3621d69) into feature (f45f735) will increase coverage by 1.15%.
The diff coverage is 100.00%.

❗ Current head 3621d69 differs from pull request most recent head b64f02f. Consider uploading reports for the commit b64f02f to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #30023      +/-   ##
===========================================
+ Coverage    98.81%   99.97%   +1.15%     
===========================================
  Files          363      397      +34     
  Lines         7280     7527     +247     
  Branches      1967     2107     +140     
===========================================
+ Hits          7194     7525     +331     
+ Misses          86        2      -84     
Impacted Files Coverage Δ
components/_util/easings.ts 100.00% <ø> (ø)
components/_util/raf.ts 100.00% <ø> (ø)
components/_util/scrollTo.ts 100.00% <ø> (ø)
components/_util/type.ts 100.00% <ø> (ø)
components/calendar/generateCalendar.tsx 100.00% <ø> (+1.33%) ⬆️
components/calendar/index.tsx 100.00% <ø> (ø)
components/card/Grid.tsx 100.00% <ø> (ø)
components/card/index.tsx 100.00% <ø> (ø)
components/_util/getScroll.tsx 100.00% <100.00%> (ø)
components/_util/hooks/useFlexGapSupport.ts 100.00% <100.00%> (ø)
... and 235 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a42fc02...b64f02f. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2021

Size Change: +130 B (0%)

Total Size: 829 kB

Filename Size Change
./dist/antd-with-locales.min.js 339 kB +62 B (0%)
./dist/antd.min.js 298 kB +68 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 63.7 kB 0 B
./dist/antd.dark.min.css 65 kB 0 B
./dist/antd.min.css 63.8 kB 0 B

compressed-size-action

@zombieJ
Copy link
Member Author

zombieJ commented Apr 6, 2021

CI passed. Pls check.

@zombieJ zombieJ merged commit ebd60df into feature Apr 6, 2021
@zombieJ zombieJ deleted the flex-gap branch April 6, 2021 03:38
afc163 pushed a commit that referenced this pull request May 6, 2021
* fix: use flex gap when supported

* test: update snapshot

* refactor: Use single hooks
chenshuai2144 added a commit that referenced this pull request May 24, 2021
* feat: add Table expandable fixed (#29959)

* fix: Use flex gap of space (#30023)

* fix: use flex gap when supported

* test: update snapshot

* refactor: Use single hooks

* feat: Allow breadcrumb component in PageHeader (#30019)

* Allow breadcrumb component in PageHeader

* Allow breadcrumb component in PageHeader

* Allow breadcrumb component in PageHeader

* Rename variable

rename var from _breadcrumbRender to breadcrumbRenderDomFromProps

* feat: add onChange for Statistic.Countdown (#30265)

* feat: add onChange for countdown

* update the demo

* feat(upload): add onDrop (#30319)

* feat(upload): Add onDrop

* Replace "if prop" logic with existential operator

* Remove redundant conditional

* feat(upload): itemRender add actions params (#30236)

* feat(upload): itemRender add actions params

* chore: optimize type definition

* chore: update doc

* chore: rename actions

* chore: trigger ci

* chore: rename method name of actions

* feat: Add missing dutch translations (#30389)

* feat: Add missing dutch translations

* fix: Translate remaining english values

* fix: Update snapshot for ui tests

* test: increase code coverage to 100% (#30415)

* test: fix Space code coverage

* test: should use nl_BE locale for DatePicker

* fix: Switch tabIndex type (#30416)

* feat: updated Romanian internationalization (#30419)

* feat: updated Romanian internationalization

* fixed lint error

* feat: Menu support accessibility & keyboard access (#30382)

* chore: Use focus style

* fix: prefixCls

* fix: prefixCls

* fix: inline tooltip

* fix: inlineCollapse logic

* fix: ts definition

* test: Update snapshot

* test: Update snapshot

* fix: dropdown logic

* test: Update snapshot

* test: Fix some test  case

* bump rc-menu

* test: More test case

* fix test finder

* test: fix test case

* test: Update snapshot

* test: Update snapshot

* chore: Update ssr effect

* test: Update ConfigProvider snapshot

* test: Fix Table Filter test case

* test: Fix table test case

* chore: Update style

* chore: beauti css

* bump rc-menu

* test: update snapshot

* test: update snapshot

* test: Fix menu test

* test: Fix test case

* test: Coverage

* chore: clean up

* bump rc-menu

* ehance accessibility style

* feat(radioGroup): support data-* and aria-* props (#30507)

close #30501

* feat: Typography add italic type (#30458)

* Typography增加斜体字支持

* update snapshot

* 文档添加版本号

Co-authored-by: lidahao <lidahao@sisyphe.com.cn>

* chore: alpha Menu fix merge (#30546)

* chore: Update script

* bump alpha version

* chore: Update script desc

* chore: bump rc-tabs & rc-mentions

* chore: Adjust style

* chore: 4.16.0-alpha.1

* test: Fix mention test case

* fix: sider of layout width style

* chore: bump 4.16.0-alpha.2

* fix: Tabs tabBarGutter should work as expected (#30545)

close #30526

* feat: Table summary support sticky mode (#30631)

* chore: Bump rc-table

* feat: Patch summary fixed color

* fix: style className

* test: Update snapshot

Co-authored-by: xrkffgg <xrkffgg@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: 二货机器人 <smith3816@gmail.com>
Co-authored-by: gepd <guillermoepd@hotmail.com>
Co-authored-by: appleshell <appleshell@outlook.com>
Co-authored-by: Eric Bonow <ebonow@hotmail.com>
Co-authored-by: xrkffgg <xrkffgg@vip.qq.com>
Co-authored-by: Kermit <kermitlx@outlook.com>
Co-authored-by: Lewis <lewisfidlers@gmail.com>
Co-authored-by: afc163 <afc163@gmail.com>
Co-authored-by: Ștefan Filip <stefy.filip@gmail.com>
Co-authored-by: vldh <alwaysloseall@sina.com>
Co-authored-by: lidahao <lidahao@sisyphe.com.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants