fix: Not try to modify lock file #29944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: +37 B (0%) Total Size: 828 kB
ℹ️ View Unchanged
|
Codecov Report
@@ Coverage Diff @@
## master #29944 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 397 397
Lines 7518 7518
Branches 2099 2099
=========================================
Hits 7518 7518
Continue to review full report at Codecov.
|
yoyo837
reviewed
Mar 30, 2021
| @@ -77,7 +77,7 @@ const InternalUpload: React.ForwardRefRenderFunction<unknown, UploadProps> = (pr | |||
| const timestamp = Date.now(); | |||
|
|
|||
| (fileList || []).forEach((file, index) => { | |||
| if (!file.uid) { | |||
| if (!file.uid && !Object.isFrozen(file)) { | |||
| file.uid = `__AUTO__${timestamp}_${index}__`; | |||
There was a problem hiding this comment.
是不是加个warning好一些？提示尝试初始化uid失败，因为啥啥啥的。
gepd
pushed a commit
to gepd/ant-design
that referenced
this pull request
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
resolve #29233
💡 Background and solution
📝 Changelog
fileListis frozen object.fileList为冻结对象时不再崩溃。☑️ Self Check before Merge