fix: Not try to modify lock file (ant-design#29944)

gepd · Apr 1, 2021 · d7ff9e9 · d7ff9e9
1 parent 251c527
commit d7ff9e9
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/components/upload/Upload.tsx b/components/upload/Upload.tsx
@@ -77,7 +77,7 @@ const InternalUpload: React.ForwardRefRenderFunction<unknown, UploadProps> = (pr
     const timestamp = Date.now();
 
     (fileList || []).forEach((file, index) => {
-      if (!file.uid) {
+      if (!file.uid && !Object.isFrozen(file)) {
         file.uid = `__AUTO__${timestamp}_${index}__`;
       }
     });
@@ -254,7 +254,7 @@ const InternalUpload: React.ForwardRefRenderFunction<unknown, UploadProps> = (pr
         currentFile = { ...file, status: 'removed' };
         mergedFileList?.forEach(item => {
           const matchKey = currentFile.uid !== undefined ? 'uid' : 'name';
-          if (item[matchKey] === currentFile[matchKey]) {
+          if (item[matchKey] === currentFile[matchKey] && !Object.isFrozen(item)) {
             item.status = 'removed';
           }
         });

diff --git a/components/upload/__tests__/upload.test.js b/components/upload/__tests__/upload.test.js
@@ -799,4 +799,27 @@ describe('Upload', () => {
       expect(key in clone).toBeTruthy();
     });
   });
+
+  it('not break on freeze object', async () => {
+    const fileList = [
+      {
+        fileName: 'Test.png',
+        name: 'SupportIS App - potwierdzenie.png',
+        thumbUrl: null,
+        downloadUrl: 'https://localhost:5001/api/files/ff2917ce-e4b9-4542-84da-31cdbe7c273f',
+        status: 'done',
+      },
+    ];
+
+    const frozenFileList = fileList.map(file => Object.freeze(file));
+
+    const wrapper = mount(<Upload fileList={frozenFileList} />);
+    const rmBtn = wrapper.find('.ant-upload-list-item-card-actions-btn').last();
+    rmBtn.simulate('click');
+
+    // Wait for Upload async remove
+    await act(async () => {
+      await sleep();
+    });
+  });
 });