Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing properties to ShowUploadListInterface #26406

Conversation

bencallaway
Copy link
Contributor

@bencallaway bencallaway commented Aug 25, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #26405

💡 Background and solution

With the addition of downloadIcon and removeIcon to the Upload component's showUploadList prop, we need to update the relevant TS interface ShowUploadListInterface. Adding these two as optional properties solves the issue.

📝 Changelog

Language Changelog
🇺🇸 English Extend ShowUploadListInterface of Upload with removeIcon and downloadIcon properties.
🇨🇳 Chinese Upload 组件 ShowUploadListInterface 类型添加 removeIcondownloadIcon 属性声明。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 25, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 25, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 25, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8eff00b:

Sandbox Source
antd reproduction template Configuration
Upload props missing type information Issue #26405

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #26406 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26406   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         383      383           
  Lines        7353     7353           
  Branches     2057     2057           
=======================================
  Hits         7335     7335           
  Misses         18       18           
Impacted Files Coverage Δ
components/upload/Upload.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 008dc3e...8eff00b. Read the comment docs.

@kerm1it
Copy link
Member

kerm1it commented Aug 26, 2020

Can you fix this type declaration?

} = showUploadList as any;

@bencallaway
Copy link
Contributor Author

Sure thing

@bencallaway bencallaway force-pushed the update-upload-props-typescript-interface branch from 9aec4cb to 8eff00b Compare August 26, 2020 10:12
@kerm1it kerm1it changed the title fix: Add missing properties to ShowUploadListInterface (#26405) fix: Add missing properties to ShowUploadListInterface Aug 26, 2020
@kerm1it kerm1it merged commit 852fad9 into ant-design:master Aug 26, 2020
@pr-triage pr-triage bot added the PR: merged label Aug 26, 2020
Copy link

@paipaii paipaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fgfdx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete TypeScript interface for ShowUploadListInterface
4 participants