fix: Add missing properties to ShowUploadListInterface (#26405)

ant-design · Aug 26, 2020 · 8eff00b · 8eff00b
1 parent 008dc3e
commit 8eff00b
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 2 deletions.
diff --git a/components/upload/Upload.tsx b/components/upload/Upload.tsx
@@ -5,6 +5,7 @@ import Dragger from './Dragger';
 import UploadList from './UploadList';
 import {
   RcFile,
+  ShowUploadListInterface,
   UploadProps,
   UploadFile,
   UploadLocale,
@@ -247,7 +248,7 @@ const InternalUpload: React.ForwardRefRenderFunction<unknown, UploadProps> = (pr
       <LocaleReceiver componentName="Upload" defaultLocale={defaultLocale.Upload}>
         {(locale: UploadLocale) => {
           const { showRemoveIcon, showPreviewIcon, showDownloadIcon, removeIcon, downloadIcon } =
-            typeof showUploadList === 'boolean' ? ({} as any) : showUploadList;
+            typeof showUploadList === 'boolean' ? ({} as ShowUploadListInterface) : showUploadList;
           return (
             <UploadList
               listType={listType}
@@ -270,7 +271,9 @@ const InternalUpload: React.ForwardRefRenderFunction<unknown, UploadProps> = (pr
           );
         }}
       </LocaleReceiver>
-    ) : button;
+    ) : (
+      button
+    );
 
   if (type === 'drag') {
     const dragCls = classNames(

diff --git a/components/upload/__tests__/type.test.tsx b/components/upload/__tests__/type.test.tsx
@@ -10,4 +10,21 @@ describe('Upload.typescript', () => {
     );
     expect(upload).toBeTruthy();
   });
+
+  it('showUploadList', () => {
+    const upload = (
+      <Upload
+        showUploadList={{
+          showPreviewIcon: true,
+          showRemoveIcon: true,
+          showDownloadIcon: true,
+          removeIcon: 'Remove',
+          downloadIcon: 'Download',
+        }}
+      >
+        <span>click to upload</span>
+      </Upload>
+    );
+    expect(upload).toBeTruthy();
+  });
 });
diff --git a/components/upload/interface.tsx b/components/upload/interface.tsx
@@ -56,6 +56,8 @@ export interface ShowUploadListInterface {
   showRemoveIcon?: boolean;
   showPreviewIcon?: boolean;
   showDownloadIcon?: boolean;
+  removeIcon?: React.ReactNode;
+  downloadIcon?: React.ReactNode;
 }
 
 export interface UploadLocale {