Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #20876: card actions font-size not controlled by theme variable #21106

Merged

Conversation

morenyang
Copy link
Contributor

Fix card component action font-size not controlled by theme variable.

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#20876

💡 Background and solution

font-size of action button in the Card component is hard-code in the stylesheet. Just change it to theme variable.

image

📝 Changelog

Language Changelog
🇺🇸 English Update font-size to theme variable in the stylesheet of the action button in card component.
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Fix card component action font-size not controlled by theme variable.
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e65b383:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jan 25, 2020

Codecov Report

Merging #21106 into 3.x-stable will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           3.x-stable   #21106   +/-   ##
===========================================
  Coverage       97.82%   97.82%           
===========================================
  Files             286      286           
  Lines            7753     7753           
  Branches         2140     2188   +48     
===========================================
  Hits             7584     7584           
  Misses            169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 674074c...e65b383. Read the comment docs.

@yoyo837 yoyo837 added the 3.x 3.x stable issue or bug fix, PR should be cherry-pick to master label Jan 26, 2020
@yoyo837 yoyo837 merged commit 6de8522 into ant-design:3.x-stable Jan 26, 2020
@pr-triage pr-triage bot added the PR: merged label Jan 26, 2020
@yoyo837
Copy link
Contributor

yoyo837 commented Jan 26, 2020

Please help us fix the same problem on master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x 3.x stable issue or bug fix, PR should be cherry-pick to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants