Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #20876 on master: card actions font-size not controlled by theme variable #21107

Merged

Conversation

morenyang
Copy link
Contributor

@morenyang morenyang commented Jan 26, 2020

Fix card component action font-size not controlled by theme variable.

Refs to: #21106 (comment)

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

close #20876
ref: #21106

馃挕 Background and solution

font-size of action button in the Card component is hard-code in the stylesheet. Just change it to theme variable.

image

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Update font-size to theme variable in the stylesheet of the action button in card component.
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Fix card component action font-size not controlled by theme variable.

(cherry picked from commit e65b383)
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jan 26, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 25e7514:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jan 26, 2020

Codecov Report

Merging #21107 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21107   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         296      296           
  Lines        6911     6911           
  Branches     1871     1918   +47     
=======================================
  Hits         6737     6737           
  Misses        174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 996b7bc...25e7514. Read the comment docs.

@yoyo837 yoyo837 merged commit 3ee4d82 into ant-design:master Jan 26, 2020
@morenyang morenyang deleted the 4.x-card-action-fontsize-variable branch January 26, 2020 09:07
@zombieJ zombieJ mentioned this pull request Jan 27, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Card footer buttons ignore font-size less variable
3 participants