Allow CPU and Memory to be templatable

[nikhilo]

Issue Type:

• Bugfix Pull Request

Plugin Name:

ecs_taskdefinition

Ansible Version:

ansible 2.0.0.2

Summary:

Currently, the module does not allow the CPU and Memory parameters to be templatable. They must be integer/long. This makes the module unusable with variables. In other words, we would need to call the module for every task definition.
This change will allow the CPU and Memory to be templatable like so,

    containers:
      - name: "nikhil-test"
        image: "nikhil-test-nginx:{{deploy_tag}}"
        memory: "{{mycontainers.nginx.memory}}"
        cpu: "{{mycontainers.nginx.cpu}}"

Example output:

Error before change:

botocore.exceptions.ParamValidationError: Parameter validation failed:
Invalid type for parameter containerDefinitions[0].memory, value: 1920, type: <type 'str'>, valid types: <type 'int'>, <type 'long'>
Invalid type for parameter containerDefinitions[0].cpu, value: 2560, type: <type 'str'>, valid types: <type 'int'>, <type 'long'>

This error is not seen with suggested change

Note

This is a clone of ansible/ansible-modules-extras#1715
I could not rebase the original PR due to losing access to the repo I originally contributed from

[simplesteph]

Hi, can you please include the following changes?
They were suggested by @rmorlok as feedback.

https://github.com/ansible/ansible-modules-extras/pull/3389/files

Thanks

[bcoca]

you can just do:

    containers:
      - name: "nikhil-test"
        image: "nikhil-test-nginx:{{deploy_tag}}"
        memory: "{{mycontainers.nginx.memory|int}}"
        cpu: "{{mycontainers.nginx.cpu|int}}"

[simplesteph]

hi @bcoca

Please see why it wouldn't work with the following:
ansible/ansible-modules-extras#2641

Many PRs used to address this:
ansible/ansible-modules-extras#3284
ansible/ansible-modules-extras#3389

The underlying issue is:
#15249

@nikhilo please merge my changes in your PR (see my message above) so we can get this merged in. Otherwise I'll also create a PR which may bring some confusion

@gregdek don't know if you saw my ping yesterday, but I accept to be a maintainer for ecs_service and ecs_taskdefinition. See ansible/ansible-modules-extras#3135 (comment)

[kkarimi]

I believe this should already be fixed with #18999 ?

[simplesteph]

@kkarimi You're right. I commented your PR as I have one small concern.

[nikhilo]

It seems to be fixed by #18999
Closing