ecs_taskdefinition: Fix int param types (Fixes #4538) #18999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkarimi
changed the title
kkarimi
changed the title
|
Great to see you merged that in. Does it play nicely with idempotence? |
|
@simplesteph Thanks and you raise a good point. The reported bug which this fixes was for task creation (which #19263 also seems to be addressing). I'll try to test the idempotence case, but we might need a new PR if there is a problem there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT NAME
ecs_taskdefinition
ANSIBLE VERSION
SUMMARY
This fixes #4538 on ansible-modules-core where given container parameters to the module are always passed on as strings in the container definition parameters, which causes an exception by boto as some parameters have to be integers.