Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __init__.py file to fix rpm builds #985

Merged
merged 1 commit into from Feb 3, 2022

Conversation

AlanCoding
Copy link
Member

I think I broke rpm builds. The install shows this:

[awx@ip-10-0-45-125 ~]$ ls /usr/lib/python3.8/site-packages/ansible_runner
cleanup.py  defaults.py    __init__.py   loader.py    output.py  __pycache__       runner.py     utils
config      exceptions.py  interface.py  __main__.py  plugins    runner_config.py  streaming.py

This is missing something very important! It doesn't have the awx_display folder with the callback plugin. For whatever reason, this seems to cause jobs to hang, which is worse than just failing.

I looked at the plugins folder, and it seems to get included with the blank file, so I want to follow suit in the obvious way here.

@AlanCoding AlanCoding requested a review from a team as a code owner February 3, 2022 02:18
@AlanCoding
Copy link
Member Author

I tried to run make rpm and it failed on

Step 5/5 : RUN pip3 install -IU ansible
 ---> Running in 62bfe8d9f751
WARNING: Running pip install with root privileges is generally not a good idea. Try `pip3 install --user` instead.
Collecting ansible
  Downloading https://files.pythonhosted.org/packages/fd/f8/071905c6a67592d0852a9f340f6ab9226861eeeb97fdf4068642b22edcf3/ansible-4.10.0.tar.gz (36.8MB)
Collecting ansible-core~=2.11.7 (from ansible)
  Downloading https://files.pythonhosted.org/packages/2a/3f/74189f84fc9a4a203fc9644cd62146ba735fd9dd17f94867a272075c3cc7/ansible-core-2.11.8.tar.gz (7.1MB)
Exception:
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/pip/basecommand.py", line 215, in main
    status = self.run(options, args)
  File "/usr/lib/python3.6/site-packages/pip/commands/install.py", line 346, in run
    requirement_set.prepare_files(finder)
  File "/usr/lib/python3.6/site-packages/pip/req/req_set.py", line 381, in prepare_files
    ignore_dependencies=self.ignore_dependencies))
  File "/usr/lib/python3.6/site-packages/pip/req/req_set.py", line 623, in _prepare_file
    session=self.session, hashes=hashes)
  File "/usr/lib/python3.6/site-packages/pip/download.py", line 821, in unpack_url
    hashes=hashes
  File "/usr/lib/python3.6/site-packages/pip/download.py", line 663, in unpack_http_url
    unpack_file(from_path, location, content_type, link)
  File "/usr/lib/python3.6/site-packages/pip/utils/__init__.py", line 615, in unpack_file
    untar_file(filename, location)
  File "/usr/lib/python3.6/site-packages/pip/utils/__init__.py", line 587, in untar_file
    with open(path, 'wb') as destfp:
UnicodeEncodeError: 'ascii' codec can't encode character '\xe9' in position 82: ordinal not in range(128)
The command '/bin/sh -c pip3 install -IU ansible' returned a non-zero code: 2
ERROR: Service 'rpm-builder' failed to build : Build failed
make: *** [Makefile:113: rpm] Error 1

@Shrews Shrews added the gate label Feb 3, 2022
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit afe9640 into ansible:devel Feb 3, 2022
@kdelee kdelee mentioned this pull request Feb 3, 2022
ansible-zuul bot pushed a commit that referenced this pull request Feb 3, 2022
fix rpm-builder build

This fixes the rpm-builder build...
the "make rpm" target it still not working for other reasons
would be great to get that fixed + add a PR check so #985 wouldn't happen

Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
Reviewed-by: David Shrewsbury <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants