Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rpm-builder build #986

Merged
merged 1 commit into from Feb 3, 2022
Merged

fix rpm-builder build #986

merged 1 commit into from Feb 3, 2022

Conversation

kdelee
Copy link
Member

@kdelee kdelee commented Feb 3, 2022

This fixes the rpm-builder build...
the "make rpm" target it still not working for other reasons

would be great to get that fixed + add a PR check so #985 wouldn't happen

This fixes the rpm-builder build...
the "make rpm" target it still not working for other reasons
@kdelee kdelee requested a review from a team as a code owner February 3, 2022 16:53
@goneri
Copy link

goneri commented Feb 3, 2022

The current image breaks our EE integration jobs:

2022-02-03 18:41:55.864995 | controller | Using /home/zuul/src/github.com/ansible/network-ee/tests/integration/ansible.cfg as config file
2022-02-03 18:41:55.864999 | controller | setting up inventory plugins
2022-02-03 18:41:55.865002 | controller | host_list declined parsing /home/zuul/src/github.com/ansible/network-ee/tests/integration/inventories/hosts.yaml as it did not pass its verify_file() method
2022-02-03 18:41:55.865005 | controller | script declined parsing /home/zuul/src/github.com/ansible/network-ee/tests/integration/inventories/hosts.yaml as it did not pass its verify_file() method
2022-02-03 18:41:55.865009 | controller | Parsed /home/zuul/src/github.com/ansible/network-ee/tests/integration/inventories/hosts.yaml inventory source with yaml plugin
2022-02-03 18:41:55.865012 | controller | ERROR! Invalid callback for stdout specified: awx_display
2022-02-03 18:41:56.209573 | controller | ERROR
2022-02-03 18:41:56.209999 | controller | {
2022-02-03 18:41:56.210090 | controller |   "delta": "0:00:02.764129",
2022-02-03 18:41:56.210160 | controller |   "end": "2022-02-03 18:41:55.884485",
2022-02-03 18:41:56.210271 | controller |   "msg": "non-zero return code",
2022-02-03 18:41:56.210405 | controller |   "rc": 1,
2022-02-03 18:41:56.210475 | controller |   "start": "2022-02-03 18:41:53.120356"
2022-02-03 18:41:56.210536 | controller | }

@Shrews
Copy link
Contributor

Shrews commented Feb 3, 2022

These packaging files should not even be in this repo, IMO. I would like to see these removed to where they belong. I'll go ahead and merge this to fix the breakage, but someone needs to work on moving these where they can be properly managed and tested.

@Shrews Shrews added the gate label Feb 3, 2022
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 90a1c26 into ansible:devel Feb 3, 2022
@simaishi
Copy link
Contributor

simaishi commented Feb 3, 2022

These packaging files should not even be in this repo, IMO. I would like to see these removed to where they belong. I'll go ahead and merge this to fix the breakage, but someone needs to work on moving these where they can be properly managed and tested.

@Shrews FYI, those are currently not used. @kdelee has expressed this can be useufl for developers (or for CI) to make sure PR doesn't break rpm build, so I added more changes in #987 as the rpm build was still broken after this PR.

@simaishi simaishi mentioned this pull request Feb 3, 2022
ansible-zuul bot pushed a commit that referenced this pull request Feb 8, 2022
Fix rpm build

Follow-up for #986. There were still multiple rpm build failures (centos 8 stream change, .spec being out-of-date, etc.).  I fixed for el8 only.
@kdelee please try this out

Reviewed-by: Elijah DeLee <kdelee@redhat.com>
Reviewed-by: David Shrewsbury <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants