New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix rpm-builder build #986
Conversation
This fixes the rpm-builder build... the "make rpm" target it still not working for other reasons
The current image breaks our EE integration jobs:
|
These packaging files should not even be in this repo, IMO. I would like to see these removed to where they belong. I'll go ahead and merge this to fix the breakage, but someone needs to work on moving these where they can be properly managed and tested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Shrews FYI, those are currently not used. @kdelee has expressed this can be useufl for developers (or for CI) to make sure PR doesn't break rpm build, so I added more changes in #987 as the rpm build was still broken after this PR. |
This fixes the rpm-builder build...
the "make rpm" target it still not working for other reasons
would be great to get that fixed + add a PR check so #985 wouldn't happen