Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect formatting in docs #930

Merged
merged 6 commits into from Dec 6, 2021

Conversation

samdoran
Copy link
Contributor

RST uses double backticks to indicate verbatim formatting but there were many places that used only a single backtick, which is correct for Markdown.

Also change the documentation config to catch these errors in CI.

@samdoran samdoran requested a review from a team as a code owner November 30, 2021 21:39
@samdoran samdoran added docs Changes to documentation needs_triage New item that needs to be triaged labels Nov 30, 2021
@samdoran samdoran marked this pull request as draft November 30, 2021 21:45
docs/conf.py Show resolved Hide resolved
RST uses double backticks to indicate verbati formatting but there were
many places that used only a single backtick, which is correct for Markdown.
Setting the default_role to 'any' is a bit indirect, but it has the effect of
catching words surround only by single backticks.

Also enable nitpicky mode which will catch bad references.
@samdoran samdoran marked this pull request as ready for review December 6, 2021 17:12
@Shrews Shrews added gate and removed needs_triage New item that needs to be triaged labels Dec 6, 2021
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 6d99dae into ansible:devel Dec 6, 2021
samdoran added a commit to samdoran/ansible-runner that referenced this pull request Dec 6, 2021
Fix incorrect formatting in docs

RST uses double backticks to indicate verbatim formatting but there were many places that used only a single backtick, which is correct for Markdown.
Also change the documentation config to catch these errors in CI.

Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com>
Reviewed-by: Sam Doran <sdoran@redhat.com>
Reviewed-by: David Shrewsbury <None>
Reviewed-by: None <None>.
(cherry picked from commit 6d99dae)

Co-authored-by: Sam Doran <sdoran@redhat.com>
ansible-zuul bot pushed a commit that referenced this pull request Dec 6, 2021
[release_2.1] Fix incorrect formatting in docs (#930)

Backport of #930 for Ansible Runner 2.1.

Reviewed-by: David Shrewsbury <None>
Reviewed-by: None <None>
@samdoran samdoran deleted the docs/fix-formatting branch December 17, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Changes to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants