Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pf5 Select* - switch from deprecated to current #4948

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

pf5 Select* - switch from deprecated to current #4948

wants to merge 4 commits into from

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Mar 28, 2024 •
edited

Part of #4935 - update deprecated imports after update to patternfly 5

Updated Select, SelectGroup, SelectOption, SelectVariant to use current Select

(~/ts-imports/splitImports.js src/**/*.{ts,tsx} | grep patternfly.react.*depr | grep Select)

src/components/ansible-repository-form.tsx:10: import { Select } from '@patternfly/react-core/deprecated';
src/components/ansible-repository-form.tsx:10: import { SelectOption } from '@patternfly/react-core/deprecated';
src/components/collection-header.tsx:12: import { Select } from '@patternfly/react-core/deprecated';
src/components/collection-header.tsx:13: import { SelectOption } from '@patternfly/react-core/deprecated';
src/components/collection-header.tsx:14: import { SelectVariant } from '@patternfly/react-core/deprecated';
src/components/compound-filter.tsx:11: import { Select } from '@patternfly/react-core/deprecated';
src/components/compound-filter.tsx:12: import { SelectGroup } from '@patternfly/react-core/deprecated';
src/components/compound-filter.tsx:13: import { SelectOption } from '@patternfly/react-core/deprecated';
src/components/compound-filter.tsx:14: import { SelectVariant } from '@patternfly/react-core/deprecated';
src/components/permission-chip-selector.tsx:4: import { Select } from '@patternfly/react-core/deprecated';
src/components/permission-chip-selector.tsx:5: import { SelectOption } from '@patternfly/react-core/deprecated';
src/components/permission-chip-selector.tsx:6: import { SelectVariant } from '@patternfly/react-core/deprecated';
src/components/sort.tsx:3: import { Select } from '@patternfly/react-core/deprecated';
src/components/sort.tsx:4: import { SelectOption } from '@patternfly/react-core/deprecated';
src/components/sort.tsx:5: import { SelectVariant } from '@patternfly/react-core/deprecated';
src/components/typeahead.tsx:3: import { Select } from '@patternfly/react-core/deprecated';
src/components/typeahead.tsx:4: import { SelectOption } from '@patternfly/react-core/deprecated';
src/components/typeahead.tsx:5: import { SelectVariant } from '@patternfly/react-core/deprecated';

@github-actions github-actions bot added the backport-4.9 This PR should be backported to stable-4.9 (2.4) label Mar 28, 2024
@himdel himdel mentioned this pull request Mar 28, 2024
Draft
@himdel himdel removed the backport-4.9 This PR should be backported to stable-4.9 (2.4) label Mar 28, 2024
@himdel himdel force-pushed the pf-select branch 4 times, most recently from 365dc29 to 1dc01ec Compare April 14, 2024 20:13
@himdel himdel force-pushed the pf-select branch 5 times, most recently from d595c3c to 238dc9c Compare April 29, 2024 03:15
@himdel himdel force-pushed the pf-select branch 5 times, most recently from b1647f2 to bcb6c2a Compare May 12, 2024 16:50
@himdel himdel mentioned this pull request May 12, 2024
Merged
@himdel himdel force-pushed the pf-select branch 2 times, most recently from 5458248 to 1c6cd3d Compare May 12, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@himdel