Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pf5 - update deprecated imports #4935

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Mar 19, 2024

Follows #4866

replace @patternfly/react-core/deprecated imports:


TODO Also deal with l10n for any new components.

// @patternfly/react-core/deprecated

Select
  clearSelectionsAriaLabel={t`Clear all`}
  createText={t`Create`}
  favoritesLabel={t`Favorites`}
  noResultsFoundText={t`No results found`}
  removeSelectionAriaLabel={t`Remove`}
  toggleAriaLabel={t`Options menu`}
(later TODOs?)
test dark mode, https://www.patternfly.org/design-foundations/colors
revisit the whole form/formhelpertext/helpertext thing into a HubFormGroup? or direct to DataForm?
use patternfly component groups instead of custom impls
consistently use PageSection

@github-actions github-actions bot added the backport-4.9 This PR should be backported to stable-4.9 (2.4) label Mar 19, 2024
@himdel himdel removed the backport-4.9 This PR should be backported to stable-4.9 (2.4) label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant