New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build and push new prebuilt docker image #225
Conversation
@sbe-arg it might be good for you to also pull this and test it with whatever methods you've used in the past as well 👍 |
Ill try to test this later today. I did similar work in another repo last week XD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a maintainer, just an interested user.
I'm very excited about this PR, not having to build the action on every workflow execution will speed things up, and make for more reliable and predictable workflows.
I do have a question about versioning. In this PR the Dockerfile pulls latest
, and I'm wondering if that will play well with explicit versions.
Dockerfile
Outdated
|
||
RUN apk --no-cache add bash git curl jq && npm install -g semver | ||
# hadolint ignore=DL3007 | ||
FROM ghcr.io/anothrnick/github-tag-action:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will this play out with versioning of the action? When a user just declares the action like this
- name: Bump version and push tag
uses: anothrNick/github-tag-action@1.55.0 # Don't use @master unless you're happy to test the latest version
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
WITH_V: true
Will GHA build version 1.55.0
of the action? Or will it be ghcr.io/anothrnick/github-tag-action:latest
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't retro build all past tags as images they will be built on demand by the local workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And moving forward the tagged images will be available?
Co-authored-by: Miguel Ferreira <miguelferreira@me.com>
Whoops fell behind on this PR, way too much going on at the mo. I'll try to get back to it maybe late this week. The call out about versioning mentioned above is warranted. Might need to do some tweaks. |
Summary of changes
Fix for #163
Do any of the followings changes break current behaviour or configuration?
How changes have been tested
Note that tests on this PR won't pass as they're run from the main branch that doesn't yet have the ghcr image:
List any unknowns
Once merged, the Action should be tested to ensure it's operating the same.