Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images left from tagging #294

Closed
floriancircly opened this issue Nov 27, 2023 · 5 comments
Closed

Images left from tagging #294

floriancircly opened this issue Nov 27, 2023 · 5 comments

Comments

@floriancircly
Copy link

Hi all.

After running the tagging job with anothrNick/github-tag-action I see a built docker image which seems a bit off because it always has the same container id and there is no obvious use for the image (after digging in the docker history I found out that the container originated from github-tag-action). Is the image necessary to create the tags and should I do the clean up manually?

jobs:
  Create_Tag:
    runs-on: [...]
    steps:
      - uses: actions/checkout@v3
        with:
          fetch-depth: "0"
      - name: Bump version and push tag
        uses: anothrNick/github-tag-action@1.67.0
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          WITH_V: true
          DEFAULT_BUMP: patch
          RELEASE_BRANCHES: main
          PRERELEASE_SUFFIX: dev
          PRERELEASE: true
          INITIAL_VERSION: 1.0.0

Thank you so much for your support!

@sbe-arg
Copy link
Collaborator

sbe-arg commented Nov 27, 2023

We never created images. We docker run from dockerfile.

@sbe-arg
Copy link
Collaborator

sbe-arg commented Nov 28, 2023

@sammcj had a go #225 in that pr but we didn't go can't remember context

@floriancircly
Copy link
Author

Maybe this helps?
history
I get this image each time i trigger the workflow. The "LABEL maintainer=Nick Sjostrom" line made me realize the images originate from this package.

@sbe-arg
Copy link
Collaborator

sbe-arg commented Dec 8, 2023

We could build images to save a few seconds of runners but the runners are billed per minute it does not really save any money and we have to continuously update the images and retrofit image builds historically to make sure they don't run with vulnerabilities from the compliance point of view. Unsure if this is the way to go.

@sbe-arg
Copy link
Collaborator

sbe-arg commented Dec 8, 2023

If you are running self hosted you could run docker prune post this action if the docker host storage is creating headaches.

@sbe-arg sbe-arg closed this as not planned Won't fix, can't repro, duplicate, stale Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants