Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Murisi/parameterized tx2 #918

Closed
wants to merge 36 commits into from
Closed

Murisi/parameterized tx2 #918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
e71718c
update paths for core split and apply many small fixes
tzemanovic Nov 4, 2022
8e40ba5
pos: replace generic types with concrete types from core
tzemanovic Nov 21, 2022
cbec11a
docs/overview: update deps graph and add a generated one too
tzemanovic Nov 21, 2022
205f047
changelog: add #733
tzemanovic Nov 25, 2022
7129ae0
Reaggregated transaction creation code.
murisi Nov 30, 2022
5a6ff55
Moved gen_shielded_transfer into ShieldedContext.
murisi Nov 30, 2022
4fff7b5
Started factoring platform dependent code out of ShieldedContext.
murisi Nov 30, 2022
dcbc058
Moved ShieldedContext into shared crate.
murisi Nov 30, 2022
a9a254b
Now attach events to decryptable transactions. Corrected the parsing …
murisi Dec 7, 2022
f5214e9
Moved query_tx_deltas into shared crate.
murisi Dec 8, 2022
e9d2d10
Started adding documentation.
murisi Dec 8, 2022
14d9731
Fixed help for show-transfers subcommand.
murisi Dec 8, 2022
8d10d2d
Started to parameterize CLI arguments.
murisi Dec 13, 2022
839d64a
Added conversion functions for arguments.
murisi Dec 13, 2022
f021fd5
Started parameterizing code by client.
murisi Dec 14, 2022
ef2210b
Removed some unnecessary parameters.
murisi Dec 14, 2022
3656016
Pass native token into tx function through args instead of Context.
murisi Dec 15, 2022
6fc585e
Removed the WASM file reading from tx.rs.
murisi Dec 15, 2022
a873163
Replaced Context parameters with Wallets.
murisi Dec 15, 2022
c327fa2
Removed Context dependency from submit_transfer.
murisi Dec 15, 2022
bc1a6b9
Reduced dependency of rpc.rs on Context.
murisi Dec 15, 2022
8cd5f1b
Now pass down Client as a parameter in ShieldedContext.
murisi Dec 15, 2022
15ccc3e
Factored out saving and loading code from Wallet.
murisi Dec 15, 2022
b0e3460
Moved Wallet into the shared crate and parameterized it by its intera…
murisi Dec 17, 2022
4c70fc4
Added some documentation.
murisi Dec 17, 2022
536fb09
Moved CLI arguments into the shared crate.
murisi Dec 17, 2022
f55b2e3
Generalized functions to depend on Client instead of HttpClient.
murisi Dec 17, 2022
74af1c8
Moved functions from rpc.rs into the shared crate.
murisi Dec 18, 2022
7b941b7
Parameterized tx functions by storage location.
murisi Dec 18, 2022
3cffd94
Started moving functions from tx.rs and rpc.rs.
murisi Dec 18, 2022
3605d72
Extended WalletUtils to allow prompting for aliases.
murisi Dec 18, 2022
398d845
Moved more tx.rs functions into shared.
murisi Dec 18, 2022
ccedcdc
Moved more tx.rs functions into shared.
murisi Dec 18, 2022
40ada64
Moved more tx.rs functions into shared.
murisi Dec 18, 2022
e16151c
Reduced usage of generic parameters.
murisi Dec 18, 2022
f97fec6
Made ShieldedUtils trait smaller.
murisi Dec 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changelog/unreleased/improvements/733-core-crate-split.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- Public parts of shared `namada` crate have been split up into a
`namada_core` crate. The `namada_proof_of_stake`, `namada_vp_prelude`
and `namada_tx_prelude` crates now depend on this `namada_core` crate.
([#733](https://github.com/anoma/namada/pull/733))
47 changes: 28 additions & 19 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ clippy-abcipp:
$(cargo) +$(nightly) clippy \
--all-targets \
--manifest-path ./vm_env/Cargo.toml \
--no-default-features \
--features "abcipp" && \
--no-default-features && \
make -C $(wasms) clippy && \
$(foreach wasm,$(wasm_templates),$(clippy-wasm) && ) true

Expand Down
10 changes: 6 additions & 4 deletions apps/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,25 +47,27 @@ std = ["ed25519-consensus/std", "rand/std", "rand_core/std"]
testing = ["dev"]

abcipp = [
"namada/abcipp",
"namada/tendermint-rpc-abcipp",
"tendermint-abcipp",
"tendermint-config-abcipp",
"tendermint-proto-abcipp",
"tendermint-rpc-abcipp",
"tower-abci-abcipp",
"namada/abcipp"
]

abciplus = [
"namada/abciplus",
"namada/tendermint-rpc",
"tendermint",
"tendermint-config",
"tendermint-rpc",
"tendermint-proto",
"tower-abci",
"namada/abciplus"
]

[dependencies]
namada = {path = "../shared", features = ["wasm-runtime", "ferveo-tpke", "rand", "tendermint-rpc", "secp256k1-sign-verify"]}
namada = {path = "../shared", default-features = false, features = ["wasm-runtime", "ferveo-tpke", "masp-tx-gen"]}
ark-serialize = "0.3.0"
ark-std = "0.3.0"
# branch = "bat/arse-merkle-tree"
Expand Down Expand Up @@ -148,7 +150,7 @@ rust_decimal = "1.26.1"
rust_decimal_macros = "1.26.1"

[dev-dependencies]
namada = {path = "../shared", features = ["testing", "wasm-runtime"]}
namada = {path = "../shared", default-features = false, features = ["testing", "wasm-runtime"]}
bit-set = "0.5.2"
# A fork with state machime testing
proptest = {git = "https://github.com/heliaxdev/proptest", branch = "tomas/sm"}
Expand Down