Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Murisi/parameterized tx2 #918

Closed
wants to merge 36 commits into from
Closed

Murisi/parameterized tx2 #918

wants to merge 36 commits into from

Conversation

murisi
Copy link
Contributor

@murisi murisi commented Dec 18, 2022

An attempt to move functionality from tx.rs, rpc.rs, and signing.rs by means of parameterization by concrete clients. More concretely, the following changes were made:

  • Parameterized the tx.rs and rpc.rs argument types so that they can be used with or without a Context
  • Separated the pure from the impure part of Wallet and moved the pure part into the shared crate
  • Moved the function implementations in rpc.rs and tx.rs into the shared crate leaving behind function wrappers in apps (that could then be used to capture Results and print them out in the CLI)
  • Simplified the ShieldedContext trait by removing those functions in it that have been moved into the shared crate

With this approach, for each platform ShieldedContext, WalletUtils, and just the perform function of Tendermint's Client trait would have to be implemented (since the rest of Client has default implementations specified in terms of perform) for each client.

The only dependencies added to the shared crate are toml, bimap, orion, tokio, and serde. Hopefully this should not cause issues when building WASM targets.

tzemanovic and others added 30 commits November 30, 2022 12:22
@mariari mariari mentioned this pull request Dec 19, 2022
@mariari
Copy link
Member

mariari commented Dec 19, 2022

Superseded by #921

@mariari mariari closed this Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants