Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(platform-server): call onSerialize when state is empty #47888

Closed
wants to merge 1 commit into from
Closed

fix(platform-server): call onSerialize when state is empty #47888

wants to merge 1 commit into from

Commits on Oct 27, 2022

  1. fix(platform-server): call onSerialize when state is empty 

    Commit angular@a0b2d36#diff-3975e0ee5aa3e06ecbcd76f5fa5134612f7fd2e6802ca7d370973bd410aab55cR25-R31 changed the serialization phase logic so
that when the state is empty the script tag is not added to the document. As a side effect, this caused the `toJson` not called which caused the `onSerialize` callbacks also not to be called.
These callbacks are used to provide the value for a key when `toJson` is called. Example: ngrx/platform#101 (comment)

Closes angular#47172
    @alan-agius4
    alan-agius4 committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    e36b988 View commit details
    Browse the repository at this point in the history