fix(platform-server): call onSerialize when state is empty
#47888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
force-pushed
the
on-serial-cb
branch
from
fc39856
to
fcea25e
Compare
alan-agius4
added
the
target: patch
Closed
14 tasks
alan-agius4
requested review from
AndrewKushnir
and removed request for
alxhub
alan-agius4
force-pushed
the
on-serial-cb
branch
from
fcea25e
to
7a9d8c0
Compare
Commit angular@a0b2d36#diff-3975e0ee5aa3e06ecbcd76f5fa5134612f7fd2e6802ca7d370973bd410aab55cR25-R31 changed the serialization phase logic so that when the state is empty the script tag is not added to the document. As a side effect, this caused the `toJson` not called which caused the `onSerialize` callbacks also not to be called. These callbacks are used to provide the value for a key when `toJson` is called. Example: ngrx/platform#101 (comment) Closes angular#47172
alan-agius4
force-pushed
the
on-serial-cb
branch
from
7a9d8c0
to
e36b988
Compare
alan-agius4
added
the
action: review
alan-agius4
changed the title
onSerialize when state is emptyonSerialize when state is empty
AndrewKushnir
removed
the
action: review
|
This PR was merged into the repository by commit 790ee17. |
alxhub
pushed a commit
that referenced
this pull request
Oct 28, 2022
Commit a0b2d36#diff-3975e0ee5aa3e06ecbcd76f5fa5134612f7fd2e6802ca7d370973bd410aab55cR25-R31 changed the serialization phase logic so that when the state is empty the script tag is not added to the document. As a side effect, this caused the `toJson` not called which caused the `onSerialize` callbacks also not to be called. These callbacks are used to provide the value for a key when `toJson` is called. Example: ngrx/platform#101 (comment) Closes #47172 PR Close #47888
alxhub
pushed a commit
that referenced
this pull request
Oct 28, 2022
Commit a0b2d36#diff-3975e0ee5aa3e06ecbcd76f5fa5134612f7fd2e6802ca7d370973bd410aab55cR25-R31 changed the serialization phase logic so that when the state is empty the script tag is not added to the document. As a side effect, this caused the `toJson` not called which caused the `onSerialize` callbacks also not to be called. These callbacks are used to provide the value for a key when `toJson` is called. Example: ngrx/platform#101 (comment) Closes #47172 PR Close #47888
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Nov 4, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.2.8` -> `14.2.9`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.2.8/14.2.9) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.2.8` -> `14.2.9`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.2.8/14.2.9) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.2.8` -> `14.2.9`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.2.8/14.2.9) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`14.2.8` -> `14.2.9`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.2.8/14.2.9) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.2.8` -> `14.2.9`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.2.8/14.2.9) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.2.8` -> `14.2.9`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.2.8/14.2.9) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.2.8` -> `14.2.9`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.2.8/14.2.9) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.2.8` -> `14.2.9`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.2.8/14.2.9) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v14.2.9`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1429-2022-11-03) [Compare Source](angular/angular@14.2.8...14.2.9) ##### platform-browser | Commit | Type | Description | | -- | -- | -- | | [92d28bdd99](angular/angular@92d28bd) | perf | resolve memory leak when using animations with shadow DOM ([#​47903](angular/angular#47903)) | ##### platform-server | Commit | Type | Description | | -- | -- | -- | | [d2d9bbf5ce](angular/angular@d2d9bbf) | fix | call `onSerialize` when state is empty ([#​47888](angular/angular#47888)) | #### Special Thanks Alan Agius, Kristiyan Kostadinov, Virginia Dooley and mgechev <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMy4yIiwidXBkYXRlZEluVmVyIjoiMzQuMTcuMSJ9--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1626 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
nouraellm
pushed a commit
to nouraellm/angular
that referenced
this pull request
Nov 6, 2022
…#47888) Commit angular@a0b2d36#diff-3975e0ee5aa3e06ecbcd76f5fa5134612f7fd2e6802ca7d370973bd410aab55cR25-R31 changed the serialization phase logic so that when the state is empty the script tag is not added to the document. As a side effect, this caused the `toJson` not called which caused the `onSerialize` callbacks also not to be called. These callbacks are used to provide the value for a key when `toJson` is called. Example: ngrx/platform#101 (comment) Closes angular#47172 PR Close angular#47888
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
…#47888) Commit angular@a0b2d36#diff-3975e0ee5aa3e06ecbcd76f5fa5134612f7fd2e6802ca7d370973bd410aab55cR25-R31 changed the serialization phase logic so that when the state is empty the script tag is not added to the document. As a side effect, this caused the `toJson` not called which caused the `onSerialize` callbacks also not to be called. These callbacks are used to provide the value for a key when `toJson` is called. Example: ngrx/platform#101 (comment) Closes angular#47172 PR Close angular#47888
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit a0b2d36#diff-3975e0ee5aa3e06ecbcd76f5fa5134612f7fd2e6802ca7d370973bd410aab55cR25-R31 changed the serialization phase logic so that when the state is empty the script tag is not added to the document. As a side effect, this caused the
toJsonnot called which caused theonSerializecallbacks also not to be called. These callbacks are used to provide the value for a key whentoJsonis called. Example: ngrx/platform#101 (comment)Closes #47172