New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(localize): update ng add schematic to support Angular CLI version 15 #47763
Conversation
e8e4bd1
to
f0f0b38
Compare
f0f0b38
to
10801c1
Compare
0adb742
to
431c079
Compare
431c079
to
6793e84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
reviewed-for: integration-tests, public-api
Prior to this, the `@angular/localize/init` was added as a polyfill which caused the `@angular/localize` types not to be included in the TypeScript program which caused errors such as the below: ``` Error: src/app/app.component.ts:9:11 - error TS2304: Cannot find name '$localize'. ``` With the recent changes in the CLI (angular/angular-cli#24032), adding `@angular/localize/init` as polyfil or in the `main.server.ts` is no longer necessary. Instead we add this as a TypeScript type. When users are running in JIT mode, we add `@angular/localize/init` as an additional entrypoint. This change also exposes the `$localize` method as a global when importing `@angular/localize`. Closes angular#47677
6793e84
to
301a8b5
Compare
…ze package is installed The `@angular/localize` entrypoint now exposes the global `$localize` method type. See: angular/angular#47763
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: public-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: integration-tests, public-api
This PR was merged into the repository by commit c9541f4. |
… 15 (#47763) Prior to this, the `@angular/localize/init` was added as a polyfill which caused the `@angular/localize` types not to be included in the TypeScript program which caused errors such as the below: ``` Error: src/app/app.component.ts:9:11 - error TS2304: Cannot find name '$localize'. ``` With the recent changes in the CLI (angular/angular-cli#24032), adding `@angular/localize/init` as polyfil or in the `main.server.ts` is no longer necessary. Instead we add this as a TypeScript type. When users are running in JIT mode, we add `@angular/localize/init` as an additional entrypoint. This change also exposes the `$localize` method as a global when importing `@angular/localize`. Closes #47677 PR Close #47763
…ze package is installed The `@angular/localize` entrypoint now exposes the global `$localize` method type. See: angular/angular#47763
…ze package is installed The `@angular/localize` entrypoint now exposes the global `$localize` method type. See: angular/angular#47763
…ze package is installed The `@angular/localize` entrypoint now exposes the global `$localize` method type. See: angular/angular#47763 (cherry picked from commit b29ae2f)
… 15 (angular#47763) Prior to this, the `@angular/localize/init` was added as a polyfill which caused the `@angular/localize` types not to be included in the TypeScript program which caused errors such as the below: ``` Error: src/app/app.component.ts:9:11 - error TS2304: Cannot find name '$localize'. ``` With the recent changes in the CLI (angular/angular-cli#24032), adding `@angular/localize/init` as polyfil or in the `main.server.ts` is no longer necessary. Instead we add this as a TypeScript type. When users are running in JIT mode, we add `@angular/localize/init` as an additional entrypoint. This change also exposes the `$localize` method as a global when importing `@angular/localize`. Closes angular#47677 PR Close angular#47763
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Prior to this, the
@angular/localize/init
was added as a polyfill which caused the@angular/localize
types not to be included in the TypeScript program which caused errors such as the below:With the recent changes in the CLI (angular/angular-cli#24032), adding
@angular/localize/init
as polyfil or in themain.server.ts
is no longer necessary. Instead we add this as a TypeScript type. When users are running in JIT mode, we add@angular/localize/init
as an additional entrypoint.This change also exposes the
$localize
method as a global when importing@angular/localize
.Closes #47677