Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update cross angular deps and lock dependencies #47717

Closed

Conversation

devversion
Copy link
Member

@devversion devversion commented Oct 10, 2022

See individual commits. Follow-up to 249384b

@jessicajaniuk jessicajaniuk added the area: build & ci Related the build and CI infrastructure of the project label Oct 10, 2022
@ngbot ngbot bot added this to the Backlog milestone Oct 10, 2022
@devversion devversion force-pushed the update-cross-deps-to-next-and-lock branch 4 times, most recently from 4344331 to dd5b40e Compare October 12, 2022 15:28
@devversion devversion added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels Oct 12, 2022
@devversion devversion marked this pull request as ready for review October 12, 2022 15:49
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: size-tracking

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 17, 2022
@ngbot
Copy link

ngbot bot commented Oct 17, 2022

I see that you just added the action: merge label, but the following checks are still failing:
    failure conflicts with base branch "main"
    pending missing required status "google-internal-tests"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Renovate no longer updated the dependencies because they were expanded
to a range. Ranges did not satisfy the `@next` tag anymore- so Renovate
did was not able to update.

This fixes the dependencies by locking them- and also updates the
versions according to our Renovate config.
Runs the Angular CLI v15 migrations for AIO.
The `main` bundle size has been reduced with the Angular CLI update.
This is not worth investigating as it's a positive side reduction likely
due to further optimizations in the Angular CLI devkit.

Also updates the other golden payload entries to capture all other CLI
related payload changes- making future payload update easier to
investigate.
@devversion devversion force-pushed the update-cross-deps-to-next-and-lock branch from dd5b40e to 9193a00 Compare October 17, 2022 09:25
@dylhunn
Copy link
Contributor

dylhunn commented Oct 17, 2022

This PR was merged into the repository by commit 4bddd90.

dylhunn pushed a commit that referenced this pull request Oct 17, 2022
Renovate no longer updated the dependencies because they were expanded
to a range. Ranges did not satisfy the `@next` tag anymore- so Renovate
did was not able to update.

This fixes the dependencies by locking them- and also updates the
versions according to our Renovate config.

PR Close #47717
dylhunn pushed a commit that referenced this pull request Oct 17, 2022
Runs the Angular CLI v15 migrations for AIO.

PR Close #47717
dylhunn pushed a commit that referenced this pull request Oct 17, 2022
The `main` bundle size has been reduced with the Angular CLI update.
This is not worth investigating as it's a positive side reduction likely
due to further optimizations in the Angular CLI devkit.

Also updates the other golden payload entries to capture all other CLI
related payload changes- making future payload update easier to
investigate.

PR Close #47717
@dylhunn dylhunn closed this in cddae07 Oct 17, 2022
dylhunn pushed a commit that referenced this pull request Oct 17, 2022
Runs the Angular CLI v15 migrations for AIO.

PR Close #47717
dylhunn pushed a commit that referenced this pull request Oct 17, 2022
The `main` bundle size has been reduced with the Angular CLI update.
This is not worth investigating as it's a positive side reduction likely
due to further optimizations in the Angular CLI devkit.

Also updates the other golden payload entries to capture all other CLI
related payload changes- making future payload update easier to
investigate.

PR Close #47717
nouraellm pushed a commit to nouraellm/angular that referenced this pull request Nov 6, 2022
Renovate no longer updated the dependencies because they were expanded
to a range. Ranges did not satisfy the `@next` tag anymore- so Renovate
did was not able to update.

This fixes the dependencies by locking them- and also updates the
versions according to our Renovate config.

PR Close angular#47717
nouraellm pushed a commit to nouraellm/angular that referenced this pull request Nov 6, 2022
Runs the Angular CLI v15 migrations for AIO.

PR Close angular#47717
nouraellm pushed a commit to nouraellm/angular that referenced this pull request Nov 6, 2022
The `main` bundle size has been reduced with the Angular CLI update.
This is not worth investigating as it's a positive side reduction likely
due to further optimizations in the Angular CLI devkit.

Also updates the other golden payload entries to capture all other CLI
related payload changes- making future payload update easier to
investigate.

PR Close angular#47717
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants