refactor(common): make the error messages tree shakable

[ramthir]

Make Long error messages tree-shakable in the production build with error codes.

fixes #40096

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• angular.io application / infrastructure changes
• Other... Please describe:

What is the current behavior?

Invalid argument errors in the pipes are not tree-shakable in the production build.

Issue Number: 40096

What is the new behavior?

Make the invalid argument errors in the pipes tree-shakable in the production build.

Does this PR introduce a breaking change?

• Yes
• No

Other information

[AndrewKushnir]

@ramthir thanks for creating this PR 👍 Just left a couple comments.

[AndrewKushnir]

@ramthir thanks for additional updates, please see a couple comments below.

[AndrewKushnir]

@ramthir the changes look good, thanks 👍

It looks like there are few places in tests that require some updates (see CI job output here) due to an error code being present in the error message. Could you please take a look when you get a chance?

[AndrewKushnir]

@ramthir thanks for additional updates, the changes look good 👍

Note: this PR would require a rebase once PR #44677 lands. PR #44677 adds golden files for error message codes (for extra protection from accidental changes) and one of the golden files would require an update to include a new error code. I will let you know once PR #44677 lands.

Thank you.

[AndrewKushnir]

@ramthir thanks for rebasing this PR. Could you please also run the following command (as suggested by the CI output):

yarn bazel run //packages/common:common_errors.accept

and include the changes into the commit? That should make the CI "green".

Thank you.

[AndrewKushnir]

@ramthir thanks for applying additional changes! 👍

[AndrewKushnir]

Reviewed-for: public-api

[AndrewKushnir]

Presubmit.

[atscott]

reviewed-for: public-api

[dylhunn]

reviewed-for: public-api

[dylhunn]

This PR was merged into the repository by commit 4307b82.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}