refactor(common): make the error messages tree shakable (#44663)

Make Long error messages tree-shakable in the production build with error codes. fixes #40096 PR Close #44663
angular · Jan 18, 2022 · 4307b82 · 4307b82
1 parent ccb73c0
commit 4307b82
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 7 deletions.
diff --git a/goldens/public-api/common/errors.md b/goldens/public-api/common/errors.md
@@ -6,6 +6,8 @@
 
 // @public
 export const enum RuntimeErrorCode {
+    // (undocumented)
+    INVALID_PIPE_ARGUMENT = 2100,
     // (undocumented)
     PARENT_NG_SWITCH_NOT_FOUND = 2000
 }

diff --git a/packages/common/src/errors.ts b/packages/common/src/errors.ts
@@ -13,4 +13,6 @@
 export const enum RuntimeErrorCode {
   // NgSwitch errors
   PARENT_NG_SWITCH_NOT_FOUND = 2000,
+  // Pipe errors
+  INVALID_PIPE_ARGUMENT = 2100
 }
diff --git a/packages/common/src/pipes/invalid_pipe_argument_error.ts b/packages/common/src/pipes/invalid_pipe_argument_error.ts
@@ -6,8 +6,13 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {Type, ɵstringify as stringify} from '@angular/core';
+import {Type, ɵRuntimeError as RuntimeError, ɵstringify as stringify} from '@angular/core';
+
+import {RuntimeErrorCode} from '../errors';
 
 export function invalidPipeArgumentError(type: Type<any>, value: Object) {
-  return Error(`InvalidPipeArgument: '${value}' for pipe '${stringify(type)}'`);
+  const errorMessage = (typeof ngDevMode === 'undefined' || ngDevMode) ?
+      `InvalidPipeArgument: '${value}' for pipe '${stringify(type)}'` :
+      '';
+  return new RuntimeError(RuntimeErrorCode.INVALID_PIPE_ARGUMENT, errorMessage);
 }
diff --git a/packages/common/test/pipes/number_pipe_spec.ts b/packages/common/test/pipes/number_pipe_spec.ts
@@ -64,9 +64,10 @@ import {ɵregisterLocaleData, ɵunregisterLocaleData} from '@angular/core';
         it('should not support other objects', () => {
           expect(() => pipe.transform({} as any))
               .toThrowError(
-                  `InvalidPipeArgument: '[object Object] is not a number' for pipe 'DecimalPipe'`);
+                  `NG02100: InvalidPipeArgument: '[object Object] is not a number' for pipe 'DecimalPipe'`);
           expect(() => pipe.transform('123abc'))
-              .toThrowError(`InvalidPipeArgument: '123abc is not a number' for pipe 'DecimalPipe'`);
+              .toThrowError(
+                  `NG02100: InvalidPipeArgument: '123abc is not a number' for pipe 'DecimalPipe'`);
         });
       });
 
@@ -108,7 +109,7 @@ import {ɵregisterLocaleData, ɵunregisterLocaleData} from '@angular/core';
         it('should not support other objects', () => {
           expect(() => pipe.transform({} as any))
               .toThrowError(
-                  `InvalidPipeArgument: '[object Object] is not a number' for pipe 'PercentPipe'`);
+                  `NG02100: InvalidPipeArgument: '[object Object] is not a number' for pipe 'PercentPipe'`);
         });
       });
     });
@@ -168,7 +169,7 @@ import {ɵregisterLocaleData, ɵunregisterLocaleData} from '@angular/core';
         it('should not support other objects', () => {
           expect(() => pipe.transform({} as any))
               .toThrowError(
-                  `InvalidPipeArgument: '[object Object] is not a number' for pipe 'CurrencyPipe'`);
+                  `NG02100: InvalidPipeArgument: '[object Object] is not a number' for pipe 'CurrencyPipe'`);
         });
 
         it('should warn if you are using the v4 signature', () => {

diff --git a/packages/core/test/bundling/router/bundle.golden_symbols.json b/packages/core/test/bundling/router/bundle.golden_symbols.json
@@ -1878,7 +1878,7 @@
     "name": "stringify"
   },
   {
-    "name": "stringify6"
+    "name": "stringify7"
   },
   {
     "name": "stringifyCSSSelector"