Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): support TypeScript 4.3 #42022
feat(core): support TypeScript 4.3 #42022
Changes from all commits
01c8ef2
59a0810
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is tslib@2.2 required by tsc@4.3? I'm just wondering if we dodge a bullet here by switching from peerdeps on tslib to deps, which now allows us to simply increment the version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question. Tslib
v2.2.0
updated the helpers for ECMAScript private fields to support instance methods, accessors and static methods (it supported private fields in previous versions already).I think only if one uses such "newly supported" type of ECMAScript private fields, the new tslib version would be required. Angular itself doesn't use them at all, so we would also be fine staying on an older version based on what I can tell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we stay on the old version and start using private fields (which might be tricky to prevent) things could break when we don't expect it. So I think it's better to update, and risk that tslib will be present in final bundles twice until the app also updates to tslib 2.2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.