feat(core): support TypeScript 4.3 #42022

devversion · 2021-05-10T15:34:04Z

Switches the repository to TypeScript 4.3 and the latest version of tslib. This involves updating the peer dependency ranges on typescript for the compiler CLI and for the Bazel package. Tests for new TypeScript features have been added to ensure compatibility with Angular's ngtsc compiler.

devversion · 2021-05-17T17:33:41Z

This is ready for review; but not ready for merge (given TS 4.3 not being released yet). It would be great to get a early review from @angular/fw-compiler and @angular/fw-ngcc, as well as @kyliau for the language-service. Please have a look 😄

aio/aio-builds-setup/dockerbuild/scripts-js/package.json

packages/animations/package.json

packages/compiler-cli/src/ngtsc/typecheck/api/symbols.ts

JoostK · 2021-05-17T18:18:41Z

packages/compiler-cli/test/ngtsc/template_typecheck_spec.ts

@@ -368,6 +368,36 @@ export declare class AnimationEvent {
      expect(diags.length).toBe(0);
    });

+    // https://devblogs.microsoft.com/typescript/announcing-typescript-4-3-beta/#separate-write-types-on-properties
+    it('should support separate write types on inputs', () => {


We should probably include a note in the documentation about input coercion that TS 4.3 onwards supports it natively.

Yeah, let's do that as a follow-up. I'd like to change the section in AIO template-typecheck.md and I'm not sure yet how that would look like.

josephperrott

Nothing seems to be an issue from my persective. google3 presubmit also started.

petebacondarwin

Looking good!

integration/typings_test_ts43/tsconfig.json

packages/compiler-cli/ngcc/src/host/esm2015_host.ts

packages/compiler-cli/ngcc/src/host/umd_host.ts

packages/compiler-cli/ngcc/test/execution/helpers.ts

packages/compiler-cli/src/ngtsc/typecheck/api/symbols.ts

packages/compiler-cli/src/ngtsc/typecheck/src/template_symbol_builder.ts

...est/compliance/test_cases/r3_compiler_compliance/components_and_directives/GOLDEN_PARTIAL.js

.../schematics/migrations/static-queries/strategies/usage_strategy/declaration_usage_visitor.ts

packages/language-service/test/reflector_host_spec.ts

packages/zone.js/lib/common/events.ts

kyliau

LGTM for language service

Switches the repository to TypeScript 4.3 and the latest version of tslib. This involves updating the peer dependency ranges on `typescript` for the compiler CLI and for the Bazel package. Tests for new TypeScript features have been added to ensure compatibility with Angular's ngtsc compiler.

…t regression Updates the compiler-cli compliance goldens. The golden updates are required due to a regression in TypeScript 4.3 that causes the emitter to not incorrectly preserve lines when emitting a node list. This can be reverted once microsoft/TypeScript#44070 is available.

ngbot · 2021-05-31T12:10:11Z

I see that you just added the action: merge label, but the following checks are still failing:
status "google3" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

IgorMinar · 2021-06-03T00:54:36Z

I reran the g3 presubmit - there is just one failure and it seems unrelated, so I'm almost certain that we'll be fine in g3.

AndrewKushnir · 2021-06-03T22:07:18Z

FYI presubmits look good and since this change is also compatible with TS 4.2 it should be safe to land. Thank you.

…t regression (#42022) Updates the compiler-cli compliance goldens. The golden updates are required due to a regression in TypeScript 4.3 that causes the emitter to not incorrectly preserve lines when emitting a node list. This can be reverted once microsoft/TypeScript#44070 is available. PR Close #42022

…it format regression (angular#42022)" This reverts commit 71e14a7.

…it format regression (#42022)" (#42600) This reverts commit 71e14a7. PR Close #42600

angular-automatic-lock-bot · 2021-07-05T16:08:49Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

…t regression (angular#42022) Updates the compiler-cli compliance goldens. The golden updates are required due to a regression in TypeScript 4.3 that causes the emitter to not incorrectly preserve lines when emitting a node list. This can be reverted once microsoft/TypeScript#44070 is available. PR Close angular#42022

google-cla bot added the cla: yes label May 10, 2021

devversion added area: core Issues related to the framework runtime state: WIP labels May 10, 2021

ngbot bot modified the milestone: Backlog May 10, 2021

devversion force-pushed the refactor/support-typescript-4.3 branch 3 times, most recently from 468786c to c93273a Compare May 17, 2021 13:58

devversion added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels May 17, 2021

devversion requested review from kyliau, a team and josephperrott May 17, 2021 17:33

JoostK reviewed May 17, 2021

View reviewed changes

josephperrott reviewed May 17, 2021

View reviewed changes

petebacondarwin reviewed May 23, 2021

View reviewed changes

devversion force-pushed the refactor/support-typescript-4.3 branch from c93273a to 2d2826a Compare May 25, 2021 14:55

devversion added the target: minor This PR is targeted for the next minor release label May 25, 2021

kyliau approved these changes May 25, 2021

View reviewed changes

devversion added 2 commits May 26, 2021 21:44

devversion force-pushed the refactor/support-typescript-4.3 branch from 2d2826a to 59a0810 Compare May 26, 2021 19:44

devversion changed the title ~~[WIP] feat(core): support TypeScript 4.3~~ feat(core): support TypeScript 4.3 May 26, 2021

devversion marked this pull request as ready for review May 26, 2021 20:31

pullapprove bot requested review from alxhub, AndrewKushnir, andrewseguin and atscott May 26, 2021 20:31

IgorMinar added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 26, 2021

devversion removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 28, 2021

devversion requested a review from petebacondarwin May 28, 2021 12:13

petebacondarwin removed request for petebacondarwin, jelbourn, JiaLiPassion, alxhub, andrewseguin and AndrewKushnir May 28, 2021 14:59

petebacondarwin removed the action: review The PR is still awaiting reviews from at least one requested reviewer label May 28, 2021

devversion added the action: merge The PR is ready for merge by the caretaker label May 31, 2021

devversion removed the action: merge The PR is ready for merge by the caretaker label May 31, 2021

devversion added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit labels Jun 3, 2021

This comment has been minimized.

Sign in to view

AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Jun 3, 2021

jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Jun 4, 2021

jessicajaniuk closed this in 25f763c Jun 4, 2021

devversion added a commit to devversion/angular that referenced this pull request Jun 18, 2021

Revert "test: update compiler-cli compliance goldens due to TS 4.3 em…

4fe9dad

…it format regression (angular#42022)" This reverts commit 71e14a7.

dylhunn pushed a commit that referenced this pull request Jun 21, 2021

Revert "test: update compiler-cli compliance goldens due to TS 4.3 em…

b8eb24e

…it format regression (#42022)" (#42600) This reverts commit 71e14a7. PR Close #42600

angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): support TypeScript 4.3 #42022

feat(core): support TypeScript 4.3 #42022

devversion commented May 10, 2021 •

edited

devversion commented May 17, 2021

JoostK May 17, 2021

devversion May 25, 2021

JoostK May 25, 2021

josephperrott left a comment

petebacondarwin left a comment

kyliau left a comment

ngbot bot commented May 31, 2021

IgorMinar commented Jun 3, 2021

This comment has been minimized.

AndrewKushnir commented Jun 3, 2021

angular-automatic-lock-bot bot commented Jul 5, 2021

feat(core): support TypeScript 4.3 #42022

feat(core): support TypeScript 4.3 #42022

Conversation

devversion commented May 10, 2021 • edited

devversion commented May 17, 2021

JoostK May 17, 2021

Choose a reason for hiding this comment

devversion May 25, 2021

Choose a reason for hiding this comment

JoostK May 25, 2021

Choose a reason for hiding this comment

josephperrott left a comment

Choose a reason for hiding this comment

petebacondarwin left a comment

Choose a reason for hiding this comment

kyliau left a comment

Choose a reason for hiding this comment

ngbot bot commented May 31, 2021

IgorMinar commented Jun 3, 2021

This comment has been minimized.

AndrewKushnir commented Jun 3, 2021

angular-automatic-lock-bot bot commented Jul 5, 2021

devversion commented May 10, 2021 •

edited