Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler): don't report parse error for interpolation inside string in property binding #40267
fix(compiler): don't report parse error for interpolation inside string in property binding #40267
Changes from 1 commit
63c1d8f
c6ae50b
dc8d6c4
ce32bdb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this is a bit inefficient, since it will continue to run through each unquoted character even
indexOf
found the start.Also I am concerned that the following string would find a false positive:
since the
{{
is in a string, it should be ignored but would be picked up by theindexOf()
, when thecharIndex
is0
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would also be clearer if you created a new function
_getInterpolationStartIndex(input, expressionStart, start)
:Then you could do:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to add a
_getInterpolationStartIndex
, because there's some other logic that looks for an interpolation start insplitInterpolation
, but the requirements there are slightly different. As for theabc '{{' }} def
case, I think I tried something similar and it was reported as a different (syntax?) error further down the compilation process.