Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): don't report parse error for interpolation inside string in property binding #40267

Closed

Commits on Dec 26, 2020

  1. fix(compiler): don't report parse error for interpolation inside stri…

    …ng in property binding
    
    Currently we check whether a property binding contains an interpolation using a regex so
    that we can throw an error. The problem is that the regex doesn't account for quotes
    which means that something like `[prop]="'{{ foo }}'"` will be considered an error, even
    though it's not actually an interpolation.
    
    These changes build on top of the logic from angular#39826 to account for interpolation
    characters inside quotes.
    
    Fixes angular#39601.
    crisbeto committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    63c1d8f View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2020

  1. fixup! fix(compiler): don't report parse error for interpolation insi…

    …de string in property binding
    crisbeto committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    c6ae50b View commit details
    Browse the repository at this point in the history
  2. fixup! fix(compiler): don't report parse error for interpolation insi…

    …de string in property binding
    crisbeto committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    dc8d6c4 View commit details
    Browse the repository at this point in the history
  3. fixup! fix(compiler): don't report parse error for interpolation insi…

    …de string in property binding
    crisbeto committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    ce32bdb View commit details
    Browse the repository at this point in the history