build: update zone.js to use the new rollup_bundle #33329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 22, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 22, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 23, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 25, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
force-pushed
the
zonejs_new_rollup_bundle
branch
from
d7a9ea5
to
51ee373
Compare
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 25, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 25, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 25, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 25, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 25, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 25, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 25, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 25, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 25, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 25, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 25, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 25, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 25, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 25, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 25, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 25, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 26, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 26, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 27, 2019
…ScriptModuleInfo
The es6 sources now have .mjs extensions so they no longer need to be re-rooted to `{package}.es6`
[0933c29d29] build: remove deps on legacy nodejs rules rollup_bundle internals
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 27, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies. The es6 sources now have .mjs extensions so they no longer need to be re-rooted to `{package}.es6`. This eliminates the need for the collect_es6_sources() function.
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Oct 27, 2019
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies. The es6 sources now have .mjs extensions so they no longer need to be re-rooted to `{package}.es6`. This eliminates the need for the collect_es6_sources() function.
gregmagolan
force-pushed
the
zonejs_new_rollup_bundle
branch
from
51ee373
to
d49bbd6
Compare
gregmagolan
changed the title
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Nov 13, 2019
This release includes nodejs cross-platform RBE fix in bazelbuild/rules_nodejs#1320 and adds `args` to terser_minified in bazelbuild/rules_nodejs#1317. These changes are needed to land a few outstanding PRs. * build: fixes for cross-platform RBE angular#33708 * build: update zone.js to use the new rollup_bundle angular#33329
|
0.40 release is out which includes the changes in the patch here. After the #33802 update lands this PR can be updated and land without patches. |
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Nov 13, 2019
This release includes nodejs cross-platform RBE fix in bazelbuild/rules_nodejs#1320 and adds `args` to terser_minified in bazelbuild/rules_nodejs#1317. These changes are needed to land a few outstanding PRs. * build: fixes for cross-platform RBE angular#33708 * build: update zone.js to use the new rollup_bundle angular#33329
14 tasks
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Nov 13, 2019
This release includes nodejs cross-platform RBE fix in bazelbuild/rules_nodejs#1320 and adds `args` to terser_minified in bazelbuild/rules_nodejs#1317. These changes are needed to land a few outstanding PRs. * build: fixes for cross-platform RBE angular#33708 * build: update zone.js to use the new rollup_bundle angular#33329 fix: fix
gregmagolan
added a commit
to gregmagolan/angular
that referenced
this pull request
Nov 13, 2019
This release includes nodejs cross-platform RBE fix in bazelbuild/rules_nodejs#1320 and adds `args` to terser_minified in bazelbuild/rules_nodejs#1317. These changes are needed to land a few outstanding PRs. * build: fixes for cross-platform RBE angular#33708 * build: update zone.js to use the new rollup_bundle angular#33329 fix: fix
kara
pushed a commit
that referenced
this pull request
Nov 13, 2019
This release includes nodejs cross-platform RBE fix in bazelbuild/rules_nodejs#1320 and adds `args` to terser_minified in bazelbuild/rules_nodejs#1317. These changes are needed to land a few outstanding PRs. * build: fixes for cross-platform RBE #33708 * build: update zone.js to use the new rollup_bundle #33329 fix: fix PR Close #33802
kara
pushed a commit
that referenced
this pull request
Nov 13, 2019
This release includes nodejs cross-platform RBE fix in bazelbuild/rules_nodejs#1320 and adds `args` to terser_minified in bazelbuild/rules_nodejs#1317. These changes are needed to land a few outstanding PRs. * build: fixes for cross-platform RBE #33708 * build: update zone.js to use the new rollup_bundle #33329 fix: fix PR Close #33802
gregmagolan
force-pushed
the
zonejs_new_rollup_bundle
branch
3 times, most recently
from
967853e
to
479823f
Compare
|
Patches to |
gregmagolan
force-pushed
the
zonejs_new_rollup_bundle
branch
from
479823f
to
0b5cfb7
Compare
josephperrott
approved these changes
Nov 14, 2019
josephperrott
added
area: build & ci
gregmagolan
force-pushed
the
zonejs_new_rollup_bundle
branch
from
0b5cfb7
to
89cd2d0
Compare
alxhub
pushed a commit
that referenced
this pull request
Nov 15, 2019
alxhub
pushed a commit
that referenced
this pull request
Nov 15, 2019
alxhub
pushed a commit
that referenced
this pull request
Nov 15, 2019
kyliau
pushed a commit
to kyliau/angular
that referenced
this pull request
Nov 15, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the zone.js build to use the new nodejs
rollup_bundleandterser_minifedrules and downlevel with the auto-generatedtscrule.