Skip to content

Commit

Permalink
build: remove deps on legacy nodejs rules rollup_bundle internals
Browse files Browse the repository at this point in the history
The legacy nodejs rules rollup_bundle is now deprecated and will be removed in the nodejs rules 1.0 release due in mid-November. This PR brings in the rules_nodejs internal API deps that ng_rollup_bundle, ng_package and ls_rollup_bundle depend on into this repo to break the dependency. In the future these rules should switch to use the new rollup_bundle via a macro as done in angular#33329 but this is not possible right now due to the complication of having esm5 re-rooted ts_library dependencies.
  • Loading branch information
gregmagolan committed Oct 22, 2019
1 parent 1b8b04c commit 5666a9c
Show file tree
Hide file tree
Showing 6 changed files with 656 additions and 51 deletions.
12 changes: 10 additions & 2 deletions packages/bazel/src/ng_package/BUILD.bazel
Expand Up @@ -27,9 +27,17 @@ nodejs_binary(
install_source_map_support = False,
)

exports_files(["ng_package.bzl"])
exports_files([
"ng_package.bzl",
"rollup.config.js",
"terser_config.default.json",
])

filegroup(
name = "package_assets",
srcs = glob(["*.bzl"]) + ["BUILD.bazel"],
srcs = glob(["*.bzl"]) + [
"BUILD.bazel",
"rollup.config.js",
"terser_config.default.json",
],
)

0 comments on commit 5666a9c

Please sign in to comment.