Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngRepeat): trigger move animation #15072

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Commits on Aug 30, 2016

  1. fix(ngRepeat): trigger move animation

    ngRepeat does not trigger a move animation for items that come after inserted or deleted items. The documentation says that a move animation occurs "when an adjacent item is filtered out causing a reorder or when the item contents are reordered". With this fix, items that are moved can use an animation, such as changing the border or background color, to show a change.
    
    This will fix issue angular#15068.
    pondermatic committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    2331c42 View commit details
    Browse the repository at this point in the history
  2. style(ngRepeat) eslint does not like unused functions and requires co…

    …mparison operators with type.
    pondermatic committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    263be6b View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2016

  1. Configuration menu
    Copy the full SHA
    f3c6062 View commit details
    Browse the repository at this point in the history
  2. style(ngRepeat): kick off Travis-CI

    The previous Travis test failed because of a network issue with saucelabs.com.
    pondermatic committed Sep 1, 2016
    Configuration menu
    Copy the full SHA
    47bd3a4 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2016

  1. perf(ngRepeat): use less memory and compare less

    In the ngRepeatAction function:
    * The collection keys and values are accessed directly instead of copying them to nextBlockMap temporarily.
    * Checking the collectionIsLikeArray boolean value is faster than comparing value and type of collectionKeys and collection.
    pondermatic committed Sep 12, 2016
    Configuration menu
    Copy the full SHA
    7a98172 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d8320a1 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2017

  1. Configuration menu
    Copy the full SHA
    dcc80c1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c969ae2 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2017

  1. test(ngRepeat): Update based on feedback.

    In the 'should fire off the leave animation' test, revert change in how the animation queue is shifted to find item '2'. At one time during the refactoring of ngRepeat, the order of events in the queue changed.
    Improve title of the spec that checks for 'move' animation events when filtering items changes other items positions.
    pondermatic committed Mar 24, 2017
    Configuration menu
    Copy the full SHA
    410312c View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2017

  1. test(ngRepeat): Update based on feedback.

    Improve title of the spec that checks for 'move' animation events when filtering items changes other items positions.
    Remove unused item variable in two tests.
    pondermatic committed Mar 25, 2017
    Configuration menu
    Copy the full SHA
    4d6feb9 View commit details
    Browse the repository at this point in the history
  2. test(ngRepeat): Add 'toContainQueueItem' Jasmine matcher

    The 'ngRepeat animations' test group should not assume the order of items in the animation queue. This matcher searches the animation queue for an item with an expected element text and event.
    pondermatic committed Mar 25, 2017
    Configuration menu
    Copy the full SHA
    3b17d5d View commit details
    Browse the repository at this point in the history